Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2182)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed)

Created:
4 years, 4 months ago by alph
Modified:
4 years, 4 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, extensions-reviews_chromium.org, caseq+blink_chromium.org, shans, rjwright, blink-reviews-style_chromium.org, blink-reviews-animation_chromium.org, darktears, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, chromium-apps-reviews_chromium.org, Eric Willigers, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Use JS symbols instead of strings for eligible events. Committed: https://crrev.com/194f95fd095d1bdae2f1dfc436b53167b6334c42 Cr-Commit-Position: refs/heads/master@{#413324}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -250 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/edit/set-outer-html-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/elements/styles-1/edit-inspector-stylesheet.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-breakpoints/breakpoint-manager-listeners-count.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger/file-system-project-mapping-expected.txt View 7 chunks +26 lines, -26 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/animation/AnimationModel.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/BreakpointManager.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/ResourceScriptMapping.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Console.js View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/common/Object.js View 8 chunks +11 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/DockController.js View 1 chunk +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components/Spectrum.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/components_lazy/FilmStripView.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/BezierEditor.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ComputedStyleModel.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsBreadcrumbs.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js View 1 chunk +3 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/EmulatedDevices.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/InspectedPagePlaceholder.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js View 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/host/InspectorFrontendHostAPI.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/profiler/ProfilesPanel.js View 2 chunks +8 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js View 2 chunks +8 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseModel.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/resources/DatabaseQueryView.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSModel.js View 1 chunk +12 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/CSSParser.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ConsoleModel.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/DOMModel.js View 2 chunks +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/HeapProfilerModel.js View 1 chunk +6 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/InspectorBackend.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js View 1 chunk +19 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/RuntimeModel.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/Script.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js View 1 chunk +8 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/source_frame/SourceFrame.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesView.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/TabbedEditorContainer.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/WatchExpressionsSidebarPane.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/LayerDetailsView.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/Layers3DView.js View 2 chunks +5 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/PaintProfilerView.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelinePanel.js View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineTreeView.js View 1 chunk +1 line, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline/TransformController.js View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/timeline_model/LayerTreeModel.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ActionRegistry.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/Context.js View 1 chunk +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/DropDownMenu.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js View 2 chunks +4 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ResizerWidget.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/SplitWidget.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TabbedPane.js View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/TextPrompt.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/ZoomManager.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui/treeoutline.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/DataGrid.js View 1 chunk +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/OverviewGrid.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/TimelineOverviewPane.js View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/FileSystemMapping.js View 1 chunk +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js View 1 chunk +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js View 1 chunk +9 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/Workspace.js View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
alph
4 years, 4 months ago (2016-08-20 01:47:33 UTC) #2
dgozman
Let's fix all of them! lgtm
4 years, 4 months ago (2016-08-20 02:02:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261933002/1
4 years, 4 months ago (2016-08-20 02:15:34 UTC) #5
commit-bot: I haz the power
Exceeded global retry quota
4 years, 4 months ago (2016-08-20 04:38:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2261933002/1
4 years, 4 months ago (2016-08-20 05:05:17 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-20 05:44:50 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-20 05:47:01 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/194f95fd095d1bdae2f1dfc436b53167b6334c42
Cr-Commit-Position: refs/heads/master@{#413324}

Powered by Google App Engine
This is Rietveld 408576698