third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js - Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js ('k') | third_party/WebKit/Source/devtools/front_end/source_frame/CodeMirrorTextEditor.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

index 02623fe55fef3466c10686d2cee117103124892f..fa95f81f0f7521edd1a9d9d4abd200c722e252cf 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js

@@ -21,14 +21,15 @@ WebInspector.TargetManager = function()

this._isSuspended = false;

}

+/** @enum {symbol} */

WebInspector.TargetManager.Events = {

- InspectedURLChanged: "InspectedURLChanged",

- MainFrameNavigated: "MainFrameNavigated",

- Load: "Load",

- PageReloadRequested: "PageReloadRequested",

- WillReloadPage: "WillReloadPage",

- TargetDisposed: "TargetDisposed",

- SuspendStateChanged: "SuspendStateChanged"

+ InspectedURLChanged: Symbol("InspectedURLChanged"),

+ MainFrameNavigated: Symbol("MainFrameNavigated"),

+ Load: Symbol("Load"),

+ PageReloadRequested: Symbol("PageReloadRequested"),

+ WillReloadPage: Symbol("WillReloadPage"),

+ TargetDisposed: Symbol("TargetDisposed"),

+ SuspendStateChanged: Symbol("SuspendStateChanged")

}

WebInspector.TargetManager.prototype = {