third_party/WebKit/Source/devtools/front_end/components/DockController.js - Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/DockController.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/common/Object.js ('k') | third_party/WebKit/Source/devtools/front_end/components/HandlerRegistry.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/components/DockController.js

diff --git a/third_party/WebKit/Source/devtools/front_end/components/DockController.js b/third_party/WebKit/Source/devtools/front_end/components/DockController.js

index ed74056d7af15d53bbbe127b8f15a09a11815134..e04e202e9b22cb02a936442390b1bfae306040f2 100644

--- a/third_party/WebKit/Source/devtools/front_end/components/DockController.js

+++ b/third_party/WebKit/Source/devtools/front_end/components/DockController.js

@@ -65,10 +65,12 @@ WebInspector.DockController.State = {

// Use BeforeDockSideChanged to do something before all the UI bits are updated,

// DockSideChanged to update UI, and AfterDockSideChanged to perform actions

// after frontend is docked/undocked in the browser.

+/** @enum {symbol} */

WebInspector.DockController.Events = {

- BeforeDockSideChanged: "BeforeDockSideChanged",

- DockSideChanged: "DockSideChanged",

- AfterDockSideChanged: "AfterDockSideChanged"

+ BeforeDockSideChanged: Symbol("BeforeDockSideChanged"),

+ DockSideChanged: Symbol("DockSideChanged"),

+ AfterDockSideChanged: Symbol("AfterDockSideChanged")

}

WebInspector.DockController.prototype = {