third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js - Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

index 6bdd17b923e6d95e8b1843552af3c56ff0c7e3ca..bffee10d84a8c6887c9a75477878c4986caaf6c0 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkRequest.js

@@ -94,14 +94,15 @@ WebInspector.NetworkRequest = function(target, requestId, url, documentURL, fram

this.connectionId = "0";

}

+/** @enum {symbol} */

WebInspector.NetworkRequest.Events = {

- FinishedLoading: "FinishedLoading",

- TimingChanged: "TimingChanged",

- RemoteAddressChanged: "RemoteAddressChanged",

- RequestHeadersChanged: "RequestHeadersChanged",

- ResponseHeadersChanged: "ResponseHeadersChanged",

- WebsocketFrameAdded: "WebsocketFrameAdded",

- EventSourceMessageAdded: "EventSourceMessageAdded",

+ FinishedLoading: Symbol("FinishedLoading"),

+ TimingChanged: Symbol("TimingChanged"),

+ RemoteAddressChanged: Symbol("RemoteAddressChanged"),

+ RequestHeadersChanged: Symbol("RequestHeadersChanged"),

+ ResponseHeadersChanged: Symbol("ResponseHeadersChanged"),

+ WebsocketFrameAdded: Symbol("WebsocketFrameAdded"),

+ EventSourceMessageAdded: Symbol("EventSourceMessageAdded")

}

/** @enum {string} */