Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js b/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js
index 9e465d9f07508ff4691fc8695cfd5e1365c4c9d5..b715d3e676618dd0bfa0cbdd9829e2cac1e5040e 100644
--- a/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/resources/DOMStorageModel.js
@@ -51,11 +51,12 @@ WebInspector.DOMStorage.storageId = function(securityOrigin, isLocalStorage)
return { securityOrigin: securityOrigin, isLocalStorage: isLocalStorage };
}
+/** @enum {symbol} */
WebInspector.DOMStorage.Events = {
- DOMStorageItemsCleared: "DOMStorageItemsCleared",
- DOMStorageItemRemoved: "DOMStorageItemRemoved",
- DOMStorageItemAdded: "DOMStorageItemAdded",
- DOMStorageItemUpdated: "DOMStorageItemUpdated"
+ DOMStorageItemsCleared: Symbol("DOMStorageItemsCleared"),
+ DOMStorageItemRemoved: Symbol("DOMStorageItemRemoved"),
+ DOMStorageItemAdded: Symbol("DOMStorageItemAdded"),
+ DOMStorageItemUpdated: Symbol("DOMStorageItemUpdated")
}
WebInspector.DOMStorage.prototype = {
@@ -122,9 +123,10 @@ WebInspector.DOMStorageModel = function(target, securityOriginManager)
this._agent = target.domstorageAgent();
}
+/** @enum {symbol} */
WebInspector.DOMStorageModel.Events = {
- DOMStorageAdded: "DOMStorageAdded",
- DOMStorageRemoved: "DOMStorageRemoved"
+ DOMStorageAdded: Symbol("DOMStorageAdded"),
+ DOMStorageRemoved: Symbol("DOMStorageRemoved")
}
WebInspector.DOMStorageModel.prototype = {

Powered by Google App Engine
This is Rietveld 408576698