Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(373)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
index 811ee9bc6590a482b990a88770b7ddd52f3f7e93..551b1e2e913ddae3aae149b74a845178c5d379d6 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/NetworkManager.js
@@ -733,9 +733,10 @@ WebInspector.MultitargetNetworkManager = function()
this._networkConditions = WebInspector.NetworkManager.NoThrottlingConditions;
}
+/** @enum {symbol} */
WebInspector.MultitargetNetworkManager.Events = {
- ConditionsChanged: "ConditionsChanged",
- UserAgentChanged: "UserAgentChanged"
+ ConditionsChanged: Symbol("ConditionsChanged"),
+ UserAgentChanged: Symbol("UserAgentChanged")
}
WebInspector.MultitargetNetworkManager.prototype = {

Powered by Google App Engine
This is Rietveld 408576698