Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
index c5acf5b36bbaf066b2f2bd8a3835c28c629131c8..a55cd3c0a17207416a5889f5c3b2dbdc030b58e6 100644
--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js
@@ -86,9 +86,10 @@ WebInspector.ExtensionServer = function()
this._initExtensions();
}
+/** @enum {symbol} */
WebInspector.ExtensionServer.Events = {
- SidebarPaneAdded: "SidebarPaneAdded",
- AuditCategoryAdded: "AuditCategoryAdded"
+ SidebarPaneAdded: Symbol("SidebarPaneAdded"),
+ AuditCategoryAdded: Symbol("AuditCategoryAdded")
}
WebInspector.ExtensionServer.prototype = {

Powered by Google App Engine
This is Rietveld 408576698