Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(708)

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
index 60942ecf363587009c166fe6a6104e1383d34e17..e79c8021c8b819ae7a530f2f3df8aedcdbe00323 100644
--- a/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
+++ b/third_party/WebKit/Source/devtools/front_end/elements/ElementsTreeOutline.js
@@ -101,12 +101,10 @@ WebInspector.ElementsTreeOutline.forDOMModel = function(domModel)
/** @typedef {{node: !WebInspector.DOMNode, isCut: boolean}} */
WebInspector.ElementsTreeOutline.ClipboardData;
-/**
- * @enum {string}
- */
+/** @enum {symbol} */
WebInspector.ElementsTreeOutline.Events = {
- SelectedNodeChanged: "SelectedNodeChanged",
- ElementsTreeUpdated: "ElementsTreeUpdated"
+ SelectedNodeChanged: Symbol("SelectedNodeChanged"),
+ ElementsTreeUpdated: Symbol("ElementsTreeUpdated")
}
/**

Powered by Google App Engine
This is Rietveld 408576698