Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(600)

Unified Diff: third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
diff --git a/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js b/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
index 89f8c8804c2aa11d86e1bcb907fd97d715409c11..b8facd4b5b7118af9344a8c1028195e3b89c1bc6 100644
--- a/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
+++ b/third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js
@@ -62,18 +62,16 @@ WebInspector.UISourceCode = function(project, url, contentType)
this._messages = [];
}
-/**
- * @enum {string}
- */
+/** @enum {symbol} */
WebInspector.UISourceCode.Events = {
- WorkingCopyChanged: "WorkingCopyChanged",
- WorkingCopyCommitted: "WorkingCopyCommitted",
- TitleChanged: "TitleChanged",
- SourceMappingChanged: "SourceMappingChanged",
- MessageAdded: "MessageAdded",
- MessageRemoved: "MessageRemoved",
- LineDecorationAdded: "LineDecorationAdded",
- LineDecorationRemoved: "LineDecorationRemoved"
+ WorkingCopyChanged: Symbol("WorkingCopyChanged"),
+ WorkingCopyCommitted: Symbol("WorkingCopyCommitted"),
+ TitleChanged: Symbol("TitleChanged"),
+ SourceMappingChanged: Symbol("SourceMappingChanged"),
+ MessageAdded: Symbol("MessageAdded"),
+ MessageRemoved: Symbol("MessageRemoved"),
+ LineDecorationAdded: Symbol("LineDecorationAdded"),
+ LineDecorationRemoved: Symbol("LineDecorationRemoved")
}
WebInspector.UISourceCode.prototype = {

Powered by Google App Engine
This is Rietveld 408576698