third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js - Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/sdk/Script.js ('k') | third_party/WebKit/Source/devtools/front_end/sdk/TargetManager.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

index fb6a4595cebd59cd3aa7eec45d3f155709566bda..7bb3d646c21f41481cfac8b5377224fb66838efa 100644

--- a/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ServiceWorkerManager.js

@@ -51,11 +51,12 @@ WebInspector.ServiceWorkerManager = function(target)

WebInspector.targetManager.addModelListener(WebInspector.RuntimeModel, WebInspector.RuntimeModel.Events.ExecutionContextCreated, this._executionContextCreated, this);

}

+/** @enum {symbol} */

WebInspector.ServiceWorkerManager.Events = {

- WorkersUpdated: "WorkersUpdated",

- RegistrationUpdated: "RegistrationUpdated",

- RegistrationErrorAdded: "RegistrationErrorAdded",

- RegistrationDeleted: "RegistrationDeleted"

+ WorkersUpdated: Symbol("WorkersUpdated"),

+ RegistrationUpdated: Symbol("RegistrationUpdated"),

+ RegistrationErrorAdded: Symbol("RegistrationErrorAdded"),

+ RegistrationDeleted: Symbol("RegistrationDeleted")

}

WebInspector.ServiceWorkerManager.prototype = {