third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js - Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkTimeCalculator.js ('k') | third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

diff --git a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

index 2f84bd24cc3588efbe80abc37a62b6c67effec9f..5bc985b1682af26492ec9379d2b552b2dcf0aba3 100644

--- a/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

+++ b/third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotDataGrids.js

@@ -60,9 +60,10 @@ WebInspector.HeapSnapshotSortableDataGrid = function(dataDisplayDelegate, column

this.addEventListener(WebInspector.DataGrid.Events.SortingChanged, this.sortingChanged, this);

}

+/** @enum {symbol} */

WebInspector.HeapSnapshotSortableDataGrid.Events = {

- ContentShown: "ContentShown",

- SortingComplete: "SortingComplete"

+ ContentShown: Symbol("ContentShown"),

+ SortingComplete: Symbol("SortingComplete")

}

WebInspector.HeapSnapshotSortableDataGrid.prototype = {

@@ -655,8 +656,9 @@ WebInspector.HeapSnapshotRetainmentDataGrid = function(dataDisplayDelegate)

WebInspector.HeapSnapshotContainmentDataGrid.call(this, dataDisplayDelegate, columns);

}

+/** @enum {symbol} */

WebInspector.HeapSnapshotRetainmentDataGrid.Events = {

- ExpandRetainersComplete: "ExpandRetainersComplete"

+ ExpandRetainersComplete: Symbol("ExpandRetainersComplete")

}

WebInspector.HeapSnapshotRetainmentDataGrid.prototype = {