Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(647)

Unified Diff: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
diff --git a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
index 92f37ac404d562490d050f294aa27967b5cec9a4..904f91f1f7793d9f8646a05a963ab532f742ba16 100644
--- a/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
+++ b/third_party/WebKit/Source/devtools/front_end/sdk/ResourceTreeModel.js
@@ -60,25 +60,26 @@ WebInspector.ResourceTreeModel = function(target, networkManager, securityOrigin
target.runtimeModel.setExecutionContextComparator(this._executionContextComparator.bind(this));
}
+/** @enum {symbol} */
WebInspector.ResourceTreeModel.EventTypes = {
- FrameAdded: "FrameAdded",
- FrameNavigated: "FrameNavigated",
- FrameDetached: "FrameDetached",
- FrameResized: "FrameResized",
- FrameWillNavigate: "FrameWillNavigate",
- MainFrameNavigated: "MainFrameNavigated",
- ResourceAdded: "ResourceAdded",
- WillLoadCachedResources: "WillLoadCachedResources",
- CachedResourcesLoaded: "CachedResourcesLoaded",
- DOMContentLoaded: "DOMContentLoaded",
- Load: "Load",
- PageReloadRequested: "PageReloadRequested",
- WillReloadPage: "WillReloadPage",
- ScreencastFrame: "ScreencastFrame",
- ScreencastVisibilityChanged: "ScreencastVisibilityChanged",
- ColorPicked: "ColorPicked",
- InterstitialShown: "InterstitialShown",
- InterstitialHidden: "InterstitialHidden"
+ FrameAdded: Symbol("FrameAdded"),
+ FrameNavigated: Symbol("FrameNavigated"),
+ FrameDetached: Symbol("FrameDetached"),
+ FrameResized: Symbol("FrameResized"),
+ FrameWillNavigate: Symbol("FrameWillNavigate"),
+ MainFrameNavigated: WebInspector.TargetManager.Events.MainFrameNavigated,
+ ResourceAdded: Symbol("ResourceAdded"),
+ WillLoadCachedResources: Symbol("WillLoadCachedResources"),
+ CachedResourcesLoaded: Symbol("CachedResourcesLoaded"),
+ DOMContentLoaded: Symbol("DOMContentLoaded"),
+ Load: WebInspector.TargetManager.Events.Load,
+ PageReloadRequested: WebInspector.TargetManager.Events.PageReloadRequested,
+ WillReloadPage: WebInspector.TargetManager.Events.WillReloadPage,
+ ScreencastFrame: Symbol("ScreencastFrame"),
+ ScreencastVisibilityChanged: Symbol("ScreencastVisibilityChanged"),
+ ColorPicked: Symbol("ColorPicked"),
+ InterstitialShown: Symbol("InterstitialShown"),
+ InterstitialHidden: Symbol("InterstitialHidden")
}
/**

Powered by Google App Engine
This is Rietveld 408576698