Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(302)

Unified Diff: third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
diff --git a/third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js b/third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
index 348655a2b619a5a9ab07b7e08ee4fa2028ebfb25..7e328582afc587e5609d42e4564e5067c9ab3467 100644
--- a/third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
+++ b/third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
@@ -56,13 +56,14 @@ WebInspector.IsolatedFileSystemManager = function()
/** @typedef {!{fileSystemName: string, rootURL: string, fileSystemPath: string}} */
WebInspector.IsolatedFileSystemManager.FileSystem;
+/** @enum {symbol} */
WebInspector.IsolatedFileSystemManager.Events = {
- FileSystemAdded: "FileSystemAdded",
- FileSystemRemoved: "FileSystemRemoved",
- FileSystemsLoaded: "FileSystemsLoaded",
- FileSystemFilesChanged: "FileSystemFilesChanged",
- ExcludedFolderAdded: "ExcludedFolderAdded",
- ExcludedFolderRemoved: "ExcludedFolderRemoved"
+ FileSystemAdded: Symbol("FileSystemAdded"),
+ FileSystemRemoved: Symbol("FileSystemRemoved"),
+ FileSystemsLoaded: Symbol("FileSystemsLoaded"),
+ FileSystemFilesChanged: Symbol("FileSystemFilesChanged"),
+ ExcludedFolderAdded: Symbol("ExcludedFolderAdded"),
+ ExcludedFolderRemoved: Symbol("ExcludedFolderRemoved")
}
WebInspector.IsolatedFileSystemManager._lastRequestId = 0;

Powered by Google App Engine
This is Rietveld 408576698