Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(822)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/Spectrum.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/Spectrum.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/Spectrum.js b/third_party/WebKit/Source/devtools/front_end/components/Spectrum.js
index 4d287e15344df4f7978f6145c9533de0119a7948..12bdf0ead69dedddc464f6289500fec736da008e 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/Spectrum.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/Spectrum.js
@@ -189,9 +189,10 @@ WebInspector.Spectrum._ChangeSource = {
Other: "Other"
}
+/** @enum {symbol} */
WebInspector.Spectrum.Events = {
- ColorChanged: "ColorChanged",
- SizeChanged: "SizeChanged"
+ ColorChanged: Symbol("ColorChanged"),
+ SizeChanged: Symbol("SizeChanged")
};
WebInspector.Spectrum._colorChipSize = 24;

Powered by Google App Engine
This is Rietveld 408576698