third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js - Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/ui/DropDownMenu.js ('k') | third_party/WebKit/Source/devtools/front_end/ui/ResizerWidget.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

index 5d71cc9ccf86ff1281cea1ec9a70908a2d94eba6..abb3f0f1b186aec031b37a319bb7f9c37e57f6cb 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/FilterBar.js

@@ -57,8 +57,9 @@ WebInspector.FilterBar.FilterBarState = {

Shown : "on"

};

+/** @enum {symbol} */

WebInspector.FilterBar.Events = {

- Toggled: "Toggled"

+ Toggled: Symbol("Toggled")

};

WebInspector.FilterBar.prototype = {

@@ -188,8 +189,9 @@ WebInspector.FilterUI = function()

{

}

+/** @enum {symbol} */

WebInspector.FilterUI.Events = {

- FilterChanged: "FilterChanged"

+ FilterChanged: Symbol("FilterChanged")

}

WebInspector.FilterUI.prototype = {