Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: third_party/WebKit/Source/devtools/front_end/common/Console.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/common/Console.js
diff --git a/third_party/WebKit/Source/devtools/front_end/common/Console.js b/third_party/WebKit/Source/devtools/front_end/common/Console.js
index db2c7586d6db287fd9dd8fa9b43650df2a728f61..df2f0c32eca72969cce514f055456b26b60d7d7f 100644
--- a/third_party/WebKit/Source/devtools/front_end/common/Console.js
+++ b/third_party/WebKit/Source/devtools/front_end/common/Console.js
@@ -12,11 +12,9 @@ WebInspector.Console = function()
this._messages = [];
}
-/**
- * @enum {string}
- */
+/** @enum {symbol} */
WebInspector.Console.Events = {
- MessageAdded: "messageAdded"
+ MessageAdded: Symbol("messageAdded")
}
/**

Powered by Google App Engine
This is Rietveld 408576698