third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js - Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js

Issue 2261933002: DevTools: Use JS symbols instead of strings for eligible events. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/emulation/InspectedPagePlaceholder.js ('k') | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js

diff --git a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js

index d60f70ddcd4696faa42a030b48694482f1da1719..3a657ffeb9e237bc4c51dada7343d746cabd1ed4 100644

--- a/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js

+++ b/third_party/WebKit/Source/devtools/front_end/extensions/ExtensionAPI.js

@@ -49,6 +49,7 @@ function defineCommonExtensionSymbols(apiPrivate)

PreviousSearchResult: "previousSearchResult"

};

+ /** @enum {string} */

apiPrivate.Events = {

AuditStarted: "audit-started-",

ButtonClicked: "button-clicked-",

@@ -62,6 +63,7 @@ function defineCommonExtensionSymbols(apiPrivate)

ViewHidden: "view-hidden-"

};

+ /** @enum {string} */

apiPrivate.Commands = {

AddAuditCategory: "addAuditCategory",

AddAuditResult: "addAuditResult",