Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
Reviewers:
Devlin
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org, stevenjb+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //extensions/browser/api from scoped_ptr to std::unique_ptr BUG=554298 Committed: https://crrev.com/ccfc5401e32e24f29847cd91f643d03ed651b19a Cr-Commit-Position: refs/heads/master@{#388616}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1615 lines, -1496 lines) Patch
M extensions/browser/api/alarms/alarm_manager.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/alarms/alarm_manager.cc View 4 chunks +9 lines, -7 lines 0 comments Download
M extensions/browser/api/alarms/alarms_api.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/api/alarms/alarms_api_unittest.cc View 9 chunks +14 lines, -12 lines 0 comments Download
M extensions/browser/api/api_resource_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/api_resource_manager_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/app_current_window_internal/app_current_window_internal_api.cc View 10 chunks +10 lines, -11 lines 0 comments Download
M extensions/browser/api/app_runtime/app_runtime_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/app_runtime/app_runtime_api.cc View 7 chunks +23 lines, -21 lines 0 comments Download
M extensions/browser/api/app_window/app_window_api.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/app_window/app_window_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/audio/audio_api.cc View 3 chunks +18 lines, -16 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_api_pairing_delegate.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_apitest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_event_router.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_event_router.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_event_router_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_private_api.cc View 7 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/bluetooth/bluetooth_private_apitest.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_api_socket.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_socket_api.h View 14 chunks +14 lines, -14 lines 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_socket_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_socket_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.h View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/browser/api/bluetooth_socket/bluetooth_socket_event_dispatcher.cc View 6 chunks +16 lines, -16 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_auth_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_api.h View 7 chunks +14 lines, -13 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_api.cc View 12 chunks +24 lines, -20 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_api_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_channel_apitest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_framer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_framer.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_framer_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_message_util.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_socket.h View 7 chunks +14 lines, -14 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_socket.cc View 6 chunks +13 lines, -10 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_socket_unittest.cc View 9 chunks +21 lines, -20 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_test_util.h View 4 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_transport.h View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/cast_channel/cast_transport.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/cast_channel/cast_transport_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/api/cast_channel/keep_alive_delegate.h View 4 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/cast_channel/keep_alive_delegate.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/cast_channel/keep_alive_delegate_unittest.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M extensions/browser/api/cast_channel/logger.h View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/cast_channel/logger.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/cast_channel/logger_unittest.cc View 7 chunks +13 lines, -12 lines 0 comments Download
M extensions/browser/api/declarative/declarative_api.cc View 6 chunks +9 lines, -7 lines 0 comments Download
M extensions/browser/api/declarative/declarative_rule.h View 17 chunks +37 lines, -36 lines 0 comments Download
M extensions/browser/api/declarative/declarative_rule_unittest.cc View 11 chunks +18 lines, -26 lines 0 comments Download
M extensions/browser/api/declarative/deduping_factory_unittest.cc View 6 chunks +12 lines, -11 lines 0 comments Download
M extensions/browser/api/declarative/rules_cache_delegate.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/declarative/rules_cache_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/declarative/rules_registry.h View 3 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/declarative/rules_registry.cc View 3 chunks +5 lines, -6 lines 0 comments Download
M extensions/browser/api/declarative/rules_registry_service.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/declarative/rules_registry_service.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/api/declarative/rules_registry_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_action.h View 2 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_action.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition.cc View 3 chunks +9 lines, -10 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.h View 3 chunks +7 lines, -5 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute.cc View 15 chunks +42 lines, -38 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_attribute_unittest.cc View 11 chunks +16 lines, -14 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_condition_unittest.cc View 14 chunks +45 lines, -45 lines 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_rules_registry.h View 2 chunks +1 line, -1 line 0 comments Download
M extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/device_permissions_manager.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/device_permissions_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/device_permissions_prompt.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/device_permissions_prompt.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/diagnostics/diagnostics_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/diagnostics/diagnostics_api_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/display_source/display_source_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/display_source/display_source_apitestbase.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/display_source/display_source_apitestbase.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M extensions/browser/api/display_source/display_source_connection_delegate_factory.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/display_source/display_source_event_router.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/display_source/wifi_display/wifi_display_session_service_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/dns/dns_api.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/dns/dns_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/dns/dns_apitest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/api/document_scan/document_scan_api.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/document_scan/document_scan_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/document_scan/document_scan_interface.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/document_scan/document_scan_interface_chromeos_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/execute_code_function.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/execute_code_function.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/extensions_api_client.h View 3 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/extensions_api_client.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/guest_view/guest_view_internal_api.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/api/guest_view/web_view/web_view_internal_api.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/guest_view/web_view/web_view_internal_api.cc View 18 chunks +19 lines, -19 lines 0 comments Download
M extensions/browser/api/hid/hid_api.h View 7 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/api/hid/hid_api.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/hid/hid_apitest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/api/hid/hid_device_manager.h View 6 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/hid/hid_device_manager.cc View 6 chunks +18 lines, -15 lines 0 comments Download
M extensions/browser/api/idle/idle_api_unittest.cc View 14 chunks +19 lines, -17 lines 0 comments Download
M extensions/browser/api/idle/idle_manager.h View 2 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/api/idle/idle_manager.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/management/management_api.h View 5 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/api/management/management_api.cc View 15 chunks +14 lines, -14 lines 0 comments Download
M extensions/browser/api/management/management_api_delegate.h View 3 chunks +6 lines, -4 lines 0 comments Download
M extensions/browser/api/messaging/native_message_host.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/messaging/native_messaging_channel.h View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/api/mime_handler_private/mime_handler_private_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/api/networking_config/networking_config_api.h View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/api/networking_config/networking_config_service.h View 4 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/networking_config/networking_config_service.cc View 5 chunks +13 lines, -10 lines 0 comments Download
M extensions/browser/api/networking_config/networking_config_service_chromeos_unittest.cc View 1 chunk +9 lines, -8 lines 0 comments Download
M extensions/browser/api/networking_config/networking_config_service_factory.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/api/networking_private/networking_private_api.h View 6 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_api.cc View 28 chunks +32 lines, -32 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_chromeos.h View 5 chunks +12 lines, -11 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_chromeos.cc View 11 chunks +13 lines, -13 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_delegate.h View 6 chunks +14 lines, -13 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/networking_private/networking_private_delegate_factory.h View 5 chunks +8 lines, -7 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_delegate_factory.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_event_router_chromeos.cc View 4 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_event_router_nonchromeos.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_linux.h View 7 chunks +16 lines, -15 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_linux.cc View 35 chunks +51 lines, -46 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_service_client.h View 7 chunks +11 lines, -10 lines 0 comments Download
M extensions/browser/api/networking_private/networking_private_service_client.cc View 11 chunks +17 lines, -16 lines 0 comments Download
M extensions/browser/api/power/power_api.h View 3 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/api/power/power_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/power/power_api_unittest.cc View 4 chunks +6 lines, -8 lines 0 comments Download
M extensions/browser/api/printer_provider/printer_provider_api.cc View 7 chunks +12 lines, -11 lines 0 comments Download
M extensions/browser/api/printer_provider/printer_provider_apitest.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M extensions/browser/api/printer_provider_internal/printer_provider_internal_api.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/printer_provider_internal/printer_provider_internal_api.cc View 8 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/api/runtime/runtime_api.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/runtime/runtime_api.cc View 9 chunks +22 lines, -22 lines 0 comments Download
M extensions/browser/api/runtime/runtime_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/serial/serial_api.h View 11 chunks +11 lines, -11 lines 0 comments Download
M extensions/browser/api/serial/serial_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/serial/serial_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/serial/serial_connection.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/serial/serial_connection.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/api/serial/serial_event_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/serial/serial_event_dispatcher.cc View 4 chunks +12 lines, -9 lines 0 comments Download
M extensions/browser/api/socket/app_firewall_hole_manager.h View 3 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/api/socket/app_firewall_hole_manager.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/socket/socket.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/socket/socket_api.h View 16 chunks +20 lines, -20 lines 0 comments Download
M extensions/browser/api/socket/socket_api.cc View 5 chunks +8 lines, -7 lines 0 comments Download
M extensions/browser/api/socket/socket_apitest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/socket/tcp_socket.h View 5 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/socket/tcp_socket.cc View 7 chunks +7 lines, -6 lines 0 comments Download
M extensions/browser/api/socket/tls_socket.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/socket/tls_socket.cc View 6 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/sockets_tcp/sockets_tcp_api.h View 13 chunks +14 lines, -14 lines 0 comments Download
M extensions/browser/api/sockets_tcp/sockets_tcp_api.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/sockets_tcp/sockets_tcp_api_unittest.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M extensions/browser/api/sockets_tcp/sockets_tcp_apitest.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.h View 8 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h View 1 chunk +4 lines, -3 lines 0 comments Download
M extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M extensions/browser/api/sockets_udp/sockets_udp_api.h View 15 chunks +15 lines, -15 lines 0 comments Download
M extensions/browser/api/sockets_udp/sockets_udp_api.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/sockets_udp/sockets_udp_api_unittest.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M extensions/browser/api/sockets_udp/sockets_udp_apitest.cc View 2 chunks +6 lines, -4 lines 0 comments Download
M extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.h View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/browser/api/sockets_udp/udp_socket_event_dispatcher.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M extensions/browser/api/storage/local_value_store_cache.h View 1 chunk +2 lines, -1 line 0 comments Download
M extensions/browser/api/storage/local_value_store_cache.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/storage/settings_quota_unittest.cc View 3 chunks +5 lines, -3 lines 0 comments Download
M extensions/browser/api/storage/settings_storage_quota_enforcer.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/storage/settings_storage_quota_enforcer.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/api/storage/settings_test_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/storage/settings_test_util.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M extensions/browser/api/storage/storage_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M extensions/browser/api/storage/storage_api_unittest.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M extensions/browser/api/storage/storage_frontend.h View 3 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/storage/storage_frontend.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M extensions/browser/api/storage/storage_frontend_unittest.cc View 5 chunks +7 lines, -5 lines 0 comments Download
M extensions/browser/api/system_cpu/cpu_info_provider_win.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/api/system_display/system_display_api.cc View 4 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/system_display/system_display_apitest.cc View 7 chunks +32 lines, -31 lines 0 comments Download
M extensions/browser/api/system_info/system_info_api.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/system_memory/system_memory_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/system_network/system_network_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/system_storage/system_storage_api.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M extensions/browser/api/system_storage/system_storage_apitest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/test/test_api.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M extensions/browser/api/usb/usb_api.h View 4 chunks +4 lines, -4 lines 0 comments Download
M extensions/browser/api/usb/usb_api.cc View 27 chunks +32 lines, -30 lines 0 comments Download
M extensions/browser/api/usb/usb_apitest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M extensions/browser/api/usb/usb_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/vpn_provider/vpn_provider_api.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M extensions/browser/api/vpn_provider/vpn_service.h View 4 chunks +7 lines, -6 lines 0 comments Download
M extensions/browser/api/vpn_provider/vpn_service.cc View 7 chunks +10 lines, -10 lines 0 comments Download
M extensions/browser/api/web_request/form_data_parser.h View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/web_request/form_data_parser.cc View 4 chunks +8 lines, -7 lines 0 comments Download
M extensions/browser/api/web_request/form_data_parser_unittest.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M extensions/browser/api/web_request/upload_data_presenter.h View 6 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/web_request/upload_data_presenter.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M extensions/browser/api/web_request/upload_data_presenter_unittest.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.h View 7 chunks +16 lines, -17 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api.cc View 28 chunks +34 lines, -34 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.h View 8 chunks +25 lines, -20 lines 0 comments Download
M extensions/browser/api/web_request/web_request_api_helpers.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M extensions/browser/api/web_request/web_request_event_details.h View 4 chunks +9 lines, -8 lines 0 comments Download
M extensions/browser/api/web_request/web_request_event_details.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M extensions/browser/api/web_request/web_request_event_router_delegate.h View 2 chunks +8 lines, -8 lines 0 comments Download
M extensions/browser/api/web_request/web_request_time_tracker.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/webcam_private/visca_webcam.h View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/browser/api/webcam_private/visca_webcam.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/api/webcam_private/visca_webcam_unittest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M extensions/browser/api/webcam_private/webcam_private_api.h View 2 chunks +2 lines, -2 lines 0 comments Download
M extensions/browser/api/webcam_private/webcam_private_api_chromeos.cc View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
dcheng
4 years, 8 months ago (2016-04-19 17:48:11 UTC) #2
Devlin
lgtm
4 years, 8 months ago (2016-04-20 19:11:13 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902873002/1
4 years, 8 months ago (2016-04-20 19:20:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/215728)
4 years, 8 months ago (2016-04-20 20:35:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902873002/1
4 years, 8 months ago (2016-04-20 20:38:31 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/215830)
4 years, 8 months ago (2016-04-20 22:03:02 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902873002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902873002/1
4 years, 8 months ago (2016-04-20 22:04:06 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 00:13:58 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 19:28:13 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ccfc5401e32e24f29847cd91f643d03ed651b19a
Cr-Commit-Position: refs/heads/master@{#388616}

Powered by Google App Engine
This is Rietveld 408576698