extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc - Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/guest_view/app_view/app_view_guest_internal_api.cc ('k') | extensions/browser/api/guest_view/guest_view_internal_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

diff --git a/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc b/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

index 878c4b583b11bd243f0920074dd07de87f63242a..53e31849d110e0edca366161845cac705438238b 100644

--- a/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

+++ b/extensions/browser/api/guest_view/extension_view/extension_view_internal_api.cc

@@ -51,7 +51,7 @@ bool IsSrcValid(GURL src) {

bool ExtensionViewInternalLoadSrcFunction::RunAsyncSafe(

ExtensionViewGuest* guest) {

- scoped_ptr<extensionview::LoadSrc::Params> params(

+ std::unique_ptr<extensionview::LoadSrc::Params> params(

extensionview::LoadSrc::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

std::string src = params->src;

@@ -69,7 +69,7 @@ bool ExtensionViewInternalLoadSrcFunction::RunAsyncSafe(

}

bool ExtensionViewInternalParseSrcFunction::RunAsync() {

- scoped_ptr<extensionview::ParseSrc::Params> params(

+ std::unique_ptr<extensionview::ParseSrc::Params> params(

extensionview::ParseSrc::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

GURL url(params->src);

@@ -77,7 +77,7 @@ bool ExtensionViewInternalParseSrcFunction::RunAsync() {

// Return whether the src is valid and the current extension ID to

// the callback.

- scoped_ptr<base::ListValue> result_list(new base::ListValue());

+ std::unique_ptr<base::ListValue> result_list(new base::ListValue());

result_list->AppendBoolean(is_src_valid);

result_list->AppendString(url.host());

SetResultList(std::move(result_list));