extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc - Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/sockets_tcp_server/sockets_tcp_server_api.cc ('k') | extensions/browser/api/sockets_tcp_server/tcp_server_socket_event_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

diff --git a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

index c54724ba7c5c64303174b04a9f20cc504c5adea6..cff342458a82160314078614b33e15f75b3c62fe 100644

--- a/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

+++ b/extensions/browser/api/sockets_tcp_server/sockets_tcp_server_apitest.cc

@@ -59,11 +59,11 @@ IN_PROC_BROWSER_TEST_F(SocketsTcpServerApiTest, SocketTCPCreateGood) {

socket_create_function->set_extension(empty_extension.get());

socket_create_function->set_has_callback(true);

- scoped_ptr<base::Value> result(

+ std::unique_ptr<base::Value> result(

api_test_utils::RunFunctionAndReturnSingleResult(

socket_create_function.get(), "[]", browser_context()));

ASSERT_EQ(base::Value::TYPE_DICTIONARY, result->GetType());

- scoped_ptr<base::DictionaryValue> value =

+ std::unique_ptr<base::DictionaryValue> value =

base::DictionaryValue::From(std::move(result));

int socketId = -1;

EXPECT_TRUE(value->GetInteger("socketId", &socketId));