Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Side by Side Diff: extensions/browser/api/cast_channel/cast_framer_unittest.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/browser/api/cast_channel/cast_framer.h" 5 #include "extensions/browser/api/cast_channel/cast_framer.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 8
9 #include <algorithm> 9 #include <algorithm>
10 #include <string> 10 #include <string>
(...skipping 24 matching lines...) Expand all
35 } 35 }
36 36
37 void WriteToBuffer(const std::string& data) { 37 void WriteToBuffer(const std::string& data) {
38 memcpy(buffer_->StartOfBuffer(), data.data(), data.size()); 38 memcpy(buffer_->StartOfBuffer(), data.data(), data.size());
39 } 39 }
40 40
41 protected: 41 protected:
42 CastMessage cast_message_; 42 CastMessage cast_message_;
43 std::string cast_message_str_; 43 std::string cast_message_str_;
44 scoped_refptr<net::GrowableIOBuffer> buffer_; 44 scoped_refptr<net::GrowableIOBuffer> buffer_;
45 scoped_ptr<MessageFramer> framer_; 45 std::unique_ptr<MessageFramer> framer_;
46 }; 46 };
47 47
48 TEST_F(CastFramerTest, TestMessageFramerCompleteMessage) { 48 TEST_F(CastFramerTest, TestMessageFramerCompleteMessage) {
49 ChannelError error; 49 ChannelError error;
50 size_t message_length; 50 size_t message_length;
51 51
52 WriteToBuffer(cast_message_str_); 52 WriteToBuffer(cast_message_str_);
53 53
54 // Receive 1 byte of the header, framer demands 3 more bytes. 54 // Receive 1 byte of the header, framer demands 3 more bytes.
55 EXPECT_EQ(4u, framer_->BytesRequested()); 55 EXPECT_EQ(4u, framer_->BytesRequested());
56 EXPECT_EQ(nullptr, framer_->Ingest(1, &message_length, &error).get()); 56 EXPECT_EQ(nullptr, framer_->Ingest(1, &message_length, &error).get());
57 EXPECT_EQ(cast_channel::CHANNEL_ERROR_NONE, error); 57 EXPECT_EQ(cast_channel::CHANNEL_ERROR_NONE, error);
58 EXPECT_EQ(3u, framer_->BytesRequested()); 58 EXPECT_EQ(3u, framer_->BytesRequested());
59 59
60 // Ingest remaining 3, expect that the framer has moved on to requesting the 60 // Ingest remaining 3, expect that the framer has moved on to requesting the
61 // body contents. 61 // body contents.
62 EXPECT_EQ(nullptr, framer_->Ingest(3, &message_length, &error).get()); 62 EXPECT_EQ(nullptr, framer_->Ingest(3, &message_length, &error).get());
63 EXPECT_EQ(cast_channel::CHANNEL_ERROR_NONE, error); 63 EXPECT_EQ(cast_channel::CHANNEL_ERROR_NONE, error);
64 EXPECT_EQ( 64 EXPECT_EQ(
65 cast_message_str_.size() - MessageFramer::MessageHeader::header_size(), 65 cast_message_str_.size() - MessageFramer::MessageHeader::header_size(),
66 framer_->BytesRequested()); 66 framer_->BytesRequested());
67 67
68 // Remainder of packet sent over the wire. 68 // Remainder of packet sent over the wire.
69 scoped_ptr<CastMessage> message; 69 std::unique_ptr<CastMessage> message;
70 message = framer_->Ingest(framer_->BytesRequested(), &message_length, &error); 70 message = framer_->Ingest(framer_->BytesRequested(), &message_length, &error);
71 EXPECT_NE(static_cast<CastMessage*>(nullptr), message.get()); 71 EXPECT_NE(static_cast<CastMessage*>(nullptr), message.get());
72 EXPECT_EQ(cast_channel::CHANNEL_ERROR_NONE, error); 72 EXPECT_EQ(cast_channel::CHANNEL_ERROR_NONE, error);
73 EXPECT_EQ(message->SerializeAsString(), cast_message_.SerializeAsString()); 73 EXPECT_EQ(message->SerializeAsString(), cast_message_.SerializeAsString());
74 EXPECT_EQ(4u, framer_->BytesRequested()); 74 EXPECT_EQ(4u, framer_->BytesRequested());
75 EXPECT_EQ(message->SerializeAsString().size(), message_length); 75 EXPECT_EQ(message->SerializeAsString().size(), message_length);
76 } 76 }
77 77
78 TEST_F(CastFramerTest, TestSerializeErrorMessageTooLarge) { 78 TEST_F(CastFramerTest, TestSerializeErrorMessageTooLarge) {
79 std::string serialized; 79 std::string serialized;
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 123
124 // Send header. 124 // Send header.
125 size_t message_length; 125 size_t message_length;
126 ChannelError error; 126 ChannelError error;
127 EXPECT_EQ(4u, framer_->BytesRequested()); 127 EXPECT_EQ(4u, framer_->BytesRequested());
128 EXPECT_EQ(nullptr, framer_->Ingest(4, &message_length, &error).get()); 128 EXPECT_EQ(nullptr, framer_->Ingest(4, &message_length, &error).get());
129 EXPECT_EQ(cast_channel::CHANNEL_ERROR_NONE, error); 129 EXPECT_EQ(cast_channel::CHANNEL_ERROR_NONE, error);
130 EXPECT_EQ(cast_message_str_.size() - 4, framer_->BytesRequested()); 130 EXPECT_EQ(cast_message_str_.size() - 4, framer_->BytesRequested());
131 131
132 // Send body, expect an error. 132 // Send body, expect an error.
133 scoped_ptr<CastMessage> message; 133 std::unique_ptr<CastMessage> message;
134 EXPECT_EQ(nullptr, framer_->Ingest(framer_->BytesRequested(), &message_length, 134 EXPECT_EQ(nullptr, framer_->Ingest(framer_->BytesRequested(), &message_length,
135 &error).get()); 135 &error).get());
136 EXPECT_EQ(cast_channel::CHANNEL_ERROR_INVALID_MESSAGE, error); 136 EXPECT_EQ(cast_channel::CHANNEL_ERROR_INVALID_MESSAGE, error);
137 } 137 }
138 } // namespace cast_channel 138 } // namespace cast_channel
139 } // namespace api 139 } // namespace api
140 } // namespace extensions 140 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/browser/api/cast_channel/cast_framer.cc ('k') | extensions/browser/api/cast_channel/cast_message_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698