extensions/browser/api/diagnostics/diagnostics_api_chromeos.cc - Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/diagnostics/diagnostics_api_chromeos.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/diagnostics/diagnostics_api.h ('k') | extensions/browser/api/display_source/display_source_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/diagnostics/diagnostics_api_chromeos.cc

diff --git a/extensions/browser/api/diagnostics/diagnostics_api_chromeos.cc b/extensions/browser/api/diagnostics/diagnostics_api_chromeos.cc

index f14b8fb0cbe60a03643b44a350f01ca8d65a3b01..6186bc7783032a1e4d50f64c1820dd4ec296a5ae 100644

--- a/extensions/browser/api/diagnostics/diagnostics_api_chromeos.cc

+++ b/extensions/browser/api/diagnostics/diagnostics_api_chromeos.cc

@@ -29,7 +29,7 @@ typedef base::Callback<void(

bool ParseResult(const std::string& status, std::string* ip, double* latency) {

// Parses the result and returns IP and latency.

- scoped_ptr<base::Value> parsed_value(base::JSONReader::Read(status));

+ std::unique_ptr<base::Value> parsed_value(base::JSONReader::Read(status));

if (!parsed_value)

return false;