extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc - Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.h ('k') | extensions/browser/api/vpn_provider/vpn_provider_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc

diff --git a/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc b/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc

index cb85a9f98f52a45dd7c97a6db44b3e5be48234de..cad4f8b9a1d3a8e3667df1712f8bd5a9af13f84e 100644

--- a/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc

+++ b/extensions/browser/api/virtual_keyboard_private/virtual_keyboard_private_api.cc

@@ -136,7 +136,7 @@ bool VirtualKeyboardPrivateOpenSettingsFunction::RunSync() {

bool VirtualKeyboardPrivateSetModeFunction::RunSync() {

VirtualKeyboardDelegate* delegate = GetDelegate(this);

if (delegate) {

- scoped_ptr<SetMode::Params> params = SetMode::Params::Create(*args_);

+ std::unique_ptr<SetMode::Params> params = SetMode::Params::Create(*args_);

EXTENSION_FUNCTION_VALIDATE(params);

if (!delegate->SetVirtualKeyboardMode(params->mode)) {

error_ = kVirtualKeyboardNotEnabled;

@@ -152,7 +152,7 @@ bool VirtualKeyboardPrivateSetModeFunction::RunSync() {

bool VirtualKeyboardPrivateSetKeyboardStateFunction::RunSync() {

VirtualKeyboardDelegate* delegate = GetDelegate(this);

if (delegate) {

- scoped_ptr<SetRequestedKeyboardState::Params> params =

+ std::unique_ptr<SetRequestedKeyboardState::Params> params =

SetRequestedKeyboardState::Params::Create(*args_);

EXTENSION_FUNCTION_VALIDATE(params);

if (!delegate->SetRequestedKeyboardState(params->state)) {