extensions/browser/api/display_source/display_source_api.cc - Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/display_source/display_source_api.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/diagnostics/diagnostics_api_chromeos.cc ('k') | extensions/browser/api/display_source/display_source_apitestbase.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/display_source/display_source_api.cc

diff --git a/extensions/browser/api/display_source/display_source_api.cc b/extensions/browser/api/display_source/display_source_api.cc

index 9b57e6b6e3b20a9bc3db3b6d60fa72ea7cb4e202..fb944130748cc8c4de724fd816a1d91c6d705886 100644

--- a/extensions/browser/api/display_source/display_source_api.cc

+++ b/extensions/browser/api/display_source/display_source_api.cc

@@ -44,7 +44,7 @@ DisplaySourceGetAvailableSinksFunction::Run() {

void DisplaySourceGetAvailableSinksFunction::OnGetSinksCompleted(

const DisplaySourceSinkInfoList& sinks) {

- scoped_ptr<base::ListValue> result =

+ std::unique_ptr<base::ListValue> result =

api::display_source::GetAvailableSinks::Results::Create(sinks);

Respond(ArgumentList(std::move(result)));

}

@@ -62,7 +62,7 @@ DisplaySourceRequestAuthenticationFunction::

ExtensionFunction::ResponseAction

DisplaySourceRequestAuthenticationFunction::Run() {

- scoped_ptr<api::display_source::RequestAuthentication::Params> params(

+ std::unique_ptr<api::display_source::RequestAuthentication::Params> params(

api::display_source::RequestAuthentication::Params::Create(*args_));

if (!params) {

return RespondNow(Error(kErrorInvalidArguments));

@@ -87,7 +87,7 @@ DisplaySourceRequestAuthenticationFunction::Run() {

void DisplaySourceRequestAuthenticationFunction::OnRequestAuthCompleted(

const DisplaySourceAuthInfo& auth_info) {

- scoped_ptr<base::ListValue> result =

+ std::unique_ptr<base::ListValue> result =

api::display_source::RequestAuthentication::Results::Create(auth_info);

Respond(ArgumentList(std::move(result)));

}