Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: extensions/browser/api/alarms/alarms_api.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/alarms/alarms_api.cc
diff --git a/extensions/browser/api/alarms/alarms_api.cc b/extensions/browser/api/alarms/alarms_api.cc
index 102bce4f8631da89641d5bc81c55d7afdcc03eb7..fa27a54d0c4b4d16d1a67abea4452aaeb8b3c563 100644
--- a/extensions/browser/api/alarms/alarms_api.cc
+++ b/extensions/browser/api/alarms/alarms_api.cc
@@ -103,7 +103,7 @@ AlarmsCreateFunction::~AlarmsCreateFunction() {
}
bool AlarmsCreateFunction::RunAsync() {
- scoped_ptr<alarms::Create::Params> params(
+ std::unique_ptr<alarms::Create::Params> params(
alarms::Create::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
const std::string& alarm_name =
@@ -135,7 +135,8 @@ void AlarmsCreateFunction::Callback() {
}
bool AlarmsGetFunction::RunAsync() {
- scoped_ptr<alarms::Get::Params> params(alarms::Get::Params::Create(*args_));
+ std::unique_ptr<alarms::Get::Params> params(
+ alarms::Get::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
std::string name = params->name.get() ? *params->name : kDefaultAlarmName;
@@ -162,7 +163,7 @@ bool AlarmsGetAllFunction::RunAsync() {
}
void AlarmsGetAllFunction::Callback(const AlarmList* alarms) {
- scoped_ptr<base::ListValue> alarms_value(new base::ListValue());
+ std::unique_ptr<base::ListValue> alarms_value(new base::ListValue());
if (alarms) {
for (const Alarm& alarm : *alarms)
alarms_value->Append(alarm.js_alarm->ToValue());
@@ -172,7 +173,7 @@ void AlarmsGetAllFunction::Callback(const AlarmList* alarms) {
}
bool AlarmsClearFunction::RunAsync() {
- scoped_ptr<alarms::Clear::Params> params(
+ std::unique_ptr<alarms::Clear::Params> params(
alarms::Clear::Params::Create(*args_));
EXTENSION_FUNCTION_VALIDATE(params.get());
« no previous file with comments | « extensions/browser/api/alarms/alarm_manager.cc ('k') | extensions/browser/api/alarms/alarms_api_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698