Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: extensions/browser/api/cast_channel/cast_framer_unittest.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/cast_channel/cast_framer_unittest.cc
diff --git a/extensions/browser/api/cast_channel/cast_framer_unittest.cc b/extensions/browser/api/cast_channel/cast_framer_unittest.cc
index 0ff968319737fb8da74114e67d0580052f2b5487..4000e1a7ab6f3f937d563c71f2757a074b843f0a 100644
--- a/extensions/browser/api/cast_channel/cast_framer_unittest.cc
+++ b/extensions/browser/api/cast_channel/cast_framer_unittest.cc
@@ -42,7 +42,7 @@ class CastFramerTest : public testing::Test {
CastMessage cast_message_;
std::string cast_message_str_;
scoped_refptr<net::GrowableIOBuffer> buffer_;
- scoped_ptr<MessageFramer> framer_;
+ std::unique_ptr<MessageFramer> framer_;
};
TEST_F(CastFramerTest, TestMessageFramerCompleteMessage) {
@@ -66,7 +66,7 @@ TEST_F(CastFramerTest, TestMessageFramerCompleteMessage) {
framer_->BytesRequested());
// Remainder of packet sent over the wire.
- scoped_ptr<CastMessage> message;
+ std::unique_ptr<CastMessage> message;
message = framer_->Ingest(framer_->BytesRequested(), &message_length, &error);
EXPECT_NE(static_cast<CastMessage*>(nullptr), message.get());
EXPECT_EQ(cast_channel::CHANNEL_ERROR_NONE, error);
@@ -130,7 +130,7 @@ TEST_F(CastFramerTest, TestUnparsableBodyProto) {
EXPECT_EQ(cast_message_str_.size() - 4, framer_->BytesRequested());
// Send body, expect an error.
- scoped_ptr<CastMessage> message;
+ std::unique_ptr<CastMessage> message;
EXPECT_EQ(nullptr, framer_->Ingest(framer_->BytesRequested(), &message_length,
&error).get());
EXPECT_EQ(cast_channel::CHANNEL_ERROR_INVALID_MESSAGE, error);
« no previous file with comments | « extensions/browser/api/cast_channel/cast_framer.cc ('k') | extensions/browser/api/cast_channel/cast_message_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698