Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Unified Diff: extensions/browser/api/web_request/upload_data_presenter_unittest.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/web_request/upload_data_presenter_unittest.cc
diff --git a/extensions/browser/api/web_request/upload_data_presenter_unittest.cc b/extensions/browser/api/web_request/upload_data_presenter_unittest.cc
index f28619dfbd3db276b80de7cf437d239086b4f791..50b648680caa0079166cd32d3af77de67938fb74 100644
--- a/extensions/browser/api/web_request/upload_data_presenter_unittest.cc
+++ b/extensions/browser/api/web_request/upload_data_presenter_unittest.cc
@@ -23,18 +23,18 @@ TEST(WebRequestUploadDataPresenterTest, ParsedData) {
net::UploadBytesElementReader element(block, sizeof(block) - 1);
// Expected output.
- scoped_ptr<base::ListValue> values(new base::ListValue);
+ std::unique_ptr<base::ListValue> values(new base::ListValue);
values->Append(new base::StringValue("value"));
base::DictionaryValue expected_form;
expected_form.SetWithoutPathExpansion("key.with.dots", values.release());
// Real output.
- scoped_ptr<ParsedDataPresenter> parsed_data_presenter(
+ std::unique_ptr<ParsedDataPresenter> parsed_data_presenter(
ParsedDataPresenter::CreateForTests());
ASSERT_TRUE(parsed_data_presenter.get() != NULL);
parsed_data_presenter->FeedNext(element);
EXPECT_TRUE(parsed_data_presenter->Succeeded());
- scoped_ptr<base::Value> result = parsed_data_presenter->Result();
+ std::unique_ptr<base::Value> result = parsed_data_presenter->Result();
ASSERT_TRUE(result.get() != NULL);
EXPECT_TRUE(result->Equals(&expected_form));
@@ -49,13 +49,13 @@ TEST(WebRequestUploadDataPresenterTest, RawData) {
const size_t block2_size = sizeof(block2) - 1;
// Expected output.
- scoped_ptr<base::BinaryValue> expected_a(
+ std::unique_ptr<base::BinaryValue> expected_a(
base::BinaryValue::CreateWithCopiedBuffer(block1, block1_size));
ASSERT_TRUE(expected_a.get() != NULL);
- scoped_ptr<base::StringValue> expected_b(
+ std::unique_ptr<base::StringValue> expected_b(
new base::StringValue(kFilename));
ASSERT_TRUE(expected_b.get() != NULL);
- scoped_ptr<base::BinaryValue> expected_c(
+ std::unique_ptr<base::BinaryValue> expected_c(
base::BinaryValue::CreateWithCopiedBuffer(block2, block2_size));
ASSERT_TRUE(expected_c.get() != NULL);
@@ -73,7 +73,7 @@ TEST(WebRequestUploadDataPresenterTest, RawData) {
raw_presenter.FeedNextFile(kFilename);
raw_presenter.FeedNextBytes(block2, block2_size);
EXPECT_TRUE(raw_presenter.Succeeded());
- scoped_ptr<base::Value> result = raw_presenter.Result();
+ std::unique_ptr<base::Value> result = raw_presenter.Result();
ASSERT_TRUE(result.get() != NULL);
EXPECT_TRUE(result->Equals(&expected_list));
« no previous file with comments | « extensions/browser/api/web_request/upload_data_presenter.cc ('k') | extensions/browser/api/web_request/web_request_api.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698