Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: extensions/browser/api/socket/app_firewall_hole_manager.h

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/socket/app_firewall_hole_manager.h
diff --git a/extensions/browser/api/socket/app_firewall_hole_manager.h b/extensions/browser/api/socket/app_firewall_hole_manager.h
index 0c125201938b7a6df56f42a24e8c21060a3686d9..d839071ab74b093c849121e16e76b6065bcd51d2 100644
--- a/extensions/browser/api/socket/app_firewall_hole_manager.h
+++ b/extensions/browser/api/socket/app_firewall_hole_manager.h
@@ -43,7 +43,8 @@ class AppFirewallHole {
const std::string& extension_id);
void SetVisible(bool app_visible);
- void OnFirewallHoleOpened(scoped_ptr<chromeos::FirewallHole> firewall_hole);
+ void OnFirewallHoleOpened(
+ std::unique_ptr<chromeos::FirewallHole> firewall_hole);
PortType type_;
uint16_t port_;
@@ -55,7 +56,7 @@ class AppFirewallHole {
AppFirewallHoleManager* manager_;
// This will hold the FirewallHole object if one is opened.
- scoped_ptr<chromeos::FirewallHole> firewall_hole_;
+ std::unique_ptr<chromeos::FirewallHole> firewall_hole_;
base::WeakPtrFactory<AppFirewallHole> weak_factory_;
};
@@ -74,9 +75,9 @@ class AppFirewallHoleManager : public KeyedService,
// Takes ownership of the AppFirewallHole and will open a port on the system
// firewall if the associated application is currently visible.
- scoped_ptr<AppFirewallHole> Open(AppFirewallHole::PortType type,
- uint16_t port,
- const std::string& extension_id);
+ std::unique_ptr<AppFirewallHole> Open(AppFirewallHole::PortType type,
+ uint16_t port,
+ const std::string& extension_id);
private:
friend class AppFirewallHole;
« no previous file with comments | « extensions/browser/api/serial/serial_event_dispatcher.cc ('k') | extensions/browser/api/socket/app_firewall_hole_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698