extensions/browser/api/storage/storage_api.cc - Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/storage/storage_api.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/storage/settings_test_util.cc ('k') | extensions/browser/api/storage/storage_api_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/storage/storage_api.cc

diff --git a/extensions/browser/api/storage/storage_api.cc b/extensions/browser/api/storage/storage_api.cc

index 16a46b0c37d7c69c4597d30f5ecd98b6ebc2175e..4b1928e471112682d329028b1099c4a257f98106 100644

--- a/extensions/browser/api/storage/storage_api.cc

+++ b/extensions/browser/api/storage/storage_api.cc

@@ -11,6 +11,7 @@

#include <vector>

#include "base/bind.h"

+#include "base/memory/ptr_util.h"

#include "base/strings/stringprintf.h"

#include "base/values.h"

#include "content/public/browser/browser_thread.h"

@@ -175,7 +176,7 @@ ExtensionFunction::ResponseValue StorageStorageAreaGetFunction::RunWithStorage(

base::DictionaryValue* with_default_values = as_dict->DeepCopy();

with_default_values->MergeDictionary(&result->settings());

return UseReadResult(ValueStore::MakeReadResult(

- make_scoped_ptr(with_default_values), result->status()));

+ base::WrapUnique(with_default_values), result->status()));

}

default:

« no previous file with comments | « extensions/browser/api/storage/settings_test_util.cc ('k') | extensions/browser/api/storage/storage_api_unittest.cc » ('j') | no next file with comments »