extensions/browser/api/device_permissions_manager.h - Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/device_permissions_manager.h

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/declarative_webrequest/webrequest_rules_registry.cc ('k') | extensions/browser/api/device_permissions_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/device_permissions_manager.h

diff --git a/extensions/browser/api/device_permissions_manager.h b/extensions/browser/api/device_permissions_manager.h

index 534abca2b4a6b678f541cce393c9a6eca94cac30..299109b5f5eb816a3fc82c9c41aa78fb48cec348 100644

--- a/extensions/browser/api/device_permissions_manager.h

+++ b/extensions/browser/api/device_permissions_manager.h

@@ -8,13 +8,13 @@

#include <stdint.h>

#include <map>

+#include <memory>

#include <set>

#include <vector>

#include "base/gtest_prod_util.h"

#include "base/macros.h"

#include "base/memory/ref_counted.h"

-#include "base/memory/scoped_ptr.h"

#include "base/scoped_observer.h"

#include "base/strings/string16.h"

#include "base/threading/thread_checker.h"

@@ -60,7 +60,7 @@ class DevicePermissionEntry : public base::RefCounted<DevicePermissionEntry> {

// Convert the device to a serializable value, returns a null pointer if the

// entry is not persistent.

- scoped_ptr<base::Value> ToValue() const;

+ std::unique_ptr<base::Value> ToValue() const;

base::string16 GetPermissionMessageString() const;