extensions/browser/api/system_storage/system_storage_api.cc - Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/system_storage/system_storage_api.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/system_network/system_network_apitest.cc ('k') | extensions/browser/api/system_storage/system_storage_apitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/system_storage/system_storage_api.cc

diff --git a/extensions/browser/api/system_storage/system_storage_api.cc b/extensions/browser/api/system_storage/system_storage_api.cc

index de460183ea3af7b2a2c459e593c9e5b54c55b873..cd20f4f6b4cf89ae74a9abb07bcb862b6d0eca6c 100644

--- a/extensions/browser/api/system_storage/system_storage_api.cc

+++ b/extensions/browser/api/system_storage/system_storage_api.cc

@@ -41,7 +41,8 @@ SystemStorageEjectDeviceFunction::~SystemStorageEjectDeviceFunction() {

bool SystemStorageEjectDeviceFunction::RunAsync() {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

- scoped_ptr<EjectDevice::Params> params(EjectDevice::Params::Create(*args_));

+ std::unique_ptr<EjectDevice::Params> params(

+ EjectDevice::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());

StorageMonitor::GetInstance()->EnsureInitialized(

@@ -102,7 +103,7 @@ SystemStorageGetAvailableCapacityFunction::

bool SystemStorageGetAvailableCapacityFunction::RunAsync() {

DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

- scoped_ptr<GetAvailableCapacity::Params> params(

+ std::unique_ptr<GetAvailableCapacity::Params> params(

GetAvailableCapacity::Params::Create(*args_));

EXTENSION_FUNCTION_VALIDATE(params.get());