extensions/browser/api/webcam_private/visca_webcam.h - Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/webcam_private/visca_webcam.h

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/web_request/web_request_time_tracker.h ('k') | extensions/browser/api/webcam_private/visca_webcam.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/webcam_private/visca_webcam.h

diff --git a/extensions/browser/api/webcam_private/visca_webcam.h b/extensions/browser/api/webcam_private/visca_webcam.h

index 0afe201f210a5fdb6a94f638954e56280b52babd..fb18fcbba6017306f74f6e58cc2368c2eb001e0f 100644

--- a/extensions/browser/api/webcam_private/visca_webcam.h

+++ b/extensions/browser/api/webcam_private/visca_webcam.h

@@ -114,13 +114,13 @@ class ViscaWebcam : public Webcam {

const SetPTZCompleteCallback& callback) override;

// Used only in unit tests in place of Open().

- void OpenForTesting(scoped_ptr<SerialConnection> serial_connection);

+ void OpenForTesting(std::unique_ptr<SerialConnection> serial_connection);

// Used only in unit tests to retrieve |serial_connection_| since this class

// owns it.

SerialConnection* GetSerialConnectionForTesting();

- scoped_ptr<SerialConnection> serial_connection_;

+ std::unique_ptr<SerialConnection> serial_connection_;

// Stores the response for the current command.

std::vector<char> data_buffer_;