extensions/browser/api/cast_channel/cast_message_util.cc - Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_message_util.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/cast_channel/cast_framer_unittest.cc ('k') | extensions/browser/api/cast_channel/cast_socket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/cast_channel/cast_message_util.cc

diff --git a/extensions/browser/api/cast_channel/cast_message_util.cc b/extensions/browser/api/cast_channel/cast_message_util.cc

index 76fa2d0218a874a9b176f09d3246688bd6234e51..f81b20aa17cef57f445093e2703541fcb4e91e4d 100644

--- a/extensions/browser/api/cast_channel/cast_message_util.cc

+++ b/extensions/browser/api/cast_channel/cast_message_util.cc

@@ -4,8 +4,9 @@

#include "extensions/browser/api/cast_channel/cast_message_util.h"

+#include <memory>

#include "base/logging.h"

-#include "base/memory/scoped_ptr.h"

#include "base/strings/string_number_conversions.h"

#include "base/values.h"

#include "extensions/common/api/cast_channel.h"

@@ -80,7 +81,7 @@ bool CastMessageToMessageInfo(const CastMessage& message_proto,

message->destination_id = message_proto.destination_id();

message->namespace_ = message_proto.namespace_();

// Determine the type of the payload and fill base::Value appropriately.

- scoped_ptr<base::Value> value;

+ std::unique_ptr<base::Value> value;

switch (message_proto.payload_type()) {

case CastMessage_PayloadType_STRING:

if (message_proto.has_payload_utf8())

« no previous file with comments | « extensions/browser/api/cast_channel/cast_framer_unittest.cc ('k') | extensions/browser/api/cast_channel/cast_socket.h » ('j') | no next file with comments »