Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2101)

Unified Diff: extensions/browser/api/networking_private/networking_private_linux.cc

Issue 1902873002: Convert //extensions/browser/api from scoped_ptr to std::unique_ptr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/networking_private/networking_private_linux.cc
diff --git a/extensions/browser/api/networking_private/networking_private_linux.cc b/extensions/browser/api/networking_private/networking_private_linux.cc
index dd489034c133a1b0dbc990d4ef134e8a66fc5601..57d34cbc44fcfb2fe37ee9f919f32d07de73a81c 100644
--- a/extensions/browser/api/networking_private/networking_private_linux.cc
+++ b/extensions/browser/api/networking_private/networking_private_linux.cc
@@ -79,9 +79,9 @@ bool GuidToSsid(const std::string& guid, std::string* ssid) {
// Iterates over the map cloning the contained networks to a
// list then returns the list.
-scoped_ptr<base::ListValue> CopyNetworkMapToList(
+std::unique_ptr<base::ListValue> CopyNetworkMapToList(
const NetworkingPrivateLinux::NetworkMap& network_map) {
- scoped_ptr<base::ListValue> network_list(new base::ListValue);
+ std::unique_ptr<base::ListValue> network_list(new base::ListValue);
for (const auto& network : network_map) {
network_list->Append(network.second->DeepCopy());
@@ -109,7 +109,7 @@ void ReportNotSupported(
// Fires the appropriate callback when the network connect operation succeeds
// or fails.
void OnNetworkConnectOperationCompleted(
- scoped_ptr<std::string> error,
+ std::unique_ptr<std::string> error,
const NetworkingPrivateDelegate::VoidCallback& success_callback,
const NetworkingPrivateDelegate::FailureCallback& failure_callback) {
if (!error->empty()) {
@@ -122,8 +122,8 @@ void OnNetworkConnectOperationCompleted(
// Fires the appropriate callback when the network properties are returned
// from the |dbus_thread_|.
void GetCachedNetworkPropertiesCallback(
- scoped_ptr<std::string> error,
- scoped_ptr<base::DictionaryValue> properties,
+ std::unique_ptr<std::string> error,
+ std::unique_ptr<base::DictionaryValue> properties,
const NetworkingPrivateDelegate::DictionaryCallback& success_callback,
const NetworkingPrivateDelegate::FailureCallback& failure_callback) {
if (!error->empty()) {
@@ -137,7 +137,7 @@ void GetCachedNetworkPropertiesCallback(
NetworkingPrivateLinux::NetworkingPrivateLinux(
content::BrowserContext* browser_context,
- scoped_ptr<VerifyDelegate> verify_delegate)
+ std::unique_ptr<VerifyDelegate> verify_delegate)
: NetworkingPrivateDelegate(std::move(verify_delegate)),
browser_context_(browser_context),
dbus_thread_("Networking Private DBus"),
@@ -211,8 +211,8 @@ void NetworkingPrivateLinux::GetState(
if (!CheckNetworkManagerSupported(failure_callback))
return;
- scoped_ptr<std::string> error(new std::string);
- scoped_ptr<base::DictionaryValue> network_properties(
+ std::unique_ptr<std::string> error(new std::string);
+ std::unique_ptr<base::DictionaryValue> network_properties(
new base::DictionaryValue);
// Runs GetCachedNetworkProperties on |dbus_thread|.
@@ -246,7 +246,7 @@ void NetworkingPrivateLinux::GetCachedNetworkProperties(
}
// Make a copy of the properties out of the cached map.
- scoped_ptr<base::DictionaryValue> temp_properties(
+ std::unique_ptr<base::DictionaryValue> temp_properties(
network_iter->second->DeepCopy());
// Swap the new copy into the dictionary that is shared with the reply.
@@ -255,7 +255,7 @@ void NetworkingPrivateLinux::GetCachedNetworkProperties(
void NetworkingPrivateLinux::SetProperties(
const std::string& guid,
- scoped_ptr<base::DictionaryValue> properties,
+ std::unique_ptr<base::DictionaryValue> properties,
const VoidCallback& success_callback,
const FailureCallback& failure_callback) {
ReportNotSupported("SetProperties", failure_callback);
@@ -263,7 +263,7 @@ void NetworkingPrivateLinux::SetProperties(
void NetworkingPrivateLinux::CreateNetwork(
bool shared,
- scoped_ptr<base::DictionaryValue> properties,
+ std::unique_ptr<base::DictionaryValue> properties,
const StringCallback& success_callback,
const FailureCallback& failure_callback) {
ReportNotSupported("CreateNetwork", failure_callback);
@@ -288,7 +288,7 @@ void NetworkingPrivateLinux::GetNetworks(
return;
}
- scoped_ptr<NetworkMap> network_map(new NetworkMap);
+ std::unique_ptr<NetworkMap> network_map(new NetworkMap);
if (!(network_type == ::onc::network_type::kWiFi ||
network_type == ::onc::network_type::kWireless ||
@@ -316,7 +316,7 @@ bool NetworkingPrivateLinux::GetNetworksForScanRequest() {
return false;
}
- scoped_ptr<NetworkMap> network_map(new NetworkMap);
+ std::unique_ptr<NetworkMap> network_map(new NetworkMap);
// Runs GetAllWiFiAccessPoints on the dbus_thread and returns the
// results back to SendNetworkListChangedEvent to fire the event. No
@@ -402,7 +402,7 @@ void NetworkingPrivateLinux::ConnectToNetwork(const std::string& guid,
builder.AppendObjectPath(device_path);
builder.AppendObjectPath(access_point_path);
- scoped_ptr<dbus::Response> response(
+ std::unique_ptr<dbus::Response> response(
network_manager_proxy_->CallMethodAndBlock(
&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT));
if (!response) {
@@ -461,7 +461,7 @@ void NetworkingPrivateLinux::DisconnectFromNetwork(const std::string& guid,
return;
}
- scoped_ptr<NetworkMap> network_map(new NetworkMap);
+ std::unique_ptr<NetworkMap> network_map(new NetworkMap);
GetAllWiFiAccessPoints(false /* configured_only */, false /* visible_only */,
0 /* limit */, network_map.get());
@@ -487,7 +487,7 @@ void NetworkingPrivateLinux::DisconnectFromNetwork(const std::string& guid,
dbus::MethodCall method_call(
networking_private::kNetworkManagerDeviceNamespace,
networking_private::kNetworkManagerDisconnectMethod);
- scoped_ptr<dbus::Response> response(device_proxy->CallMethodAndBlock(
+ std::unique_ptr<dbus::Response> response(device_proxy->CallMethodAndBlock(
&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT));
if (!response) {
@@ -504,7 +504,7 @@ void NetworkingPrivateLinux::StartConnect(
if (!CheckNetworkManagerSupported(failure_callback))
return;
- scoped_ptr<std::string> error(new std::string);
+ std::unique_ptr<std::string> error(new std::string);
// Runs ConnectToNetwork on |dbus_thread|.
dbus_thread_.task_runner()->PostTaskAndReply(
@@ -522,7 +522,7 @@ void NetworkingPrivateLinux::StartDisconnect(
if (!CheckNetworkManagerSupported(failure_callback))
return;
- scoped_ptr<std::string> error(new std::string);
+ std::unique_ptr<std::string> error(new std::string);
// Runs DisconnectFromNetwork on |dbus_thread|.
dbus_thread_.task_runner()->PostTaskAndReply(
@@ -574,16 +574,17 @@ void NetworkingPrivateLinux::SetCellularSimState(
ReportNotSupported("SetCellularSimState", failure_callback);
}
-scoped_ptr<base::ListValue> NetworkingPrivateLinux::GetEnabledNetworkTypes() {
- scoped_ptr<base::ListValue> network_list(new base::ListValue);
+std::unique_ptr<base::ListValue>
+NetworkingPrivateLinux::GetEnabledNetworkTypes() {
+ std::unique_ptr<base::ListValue> network_list(new base::ListValue);
network_list->AppendString(::onc::network_type::kWiFi);
return network_list;
}
-scoped_ptr<NetworkingPrivateDelegate::DeviceStateList>
+std::unique_ptr<NetworkingPrivateDelegate::DeviceStateList>
NetworkingPrivateLinux::GetDeviceStateList() {
- scoped_ptr<DeviceStateList> device_state_list(new DeviceStateList);
- scoped_ptr<api::networking_private::DeviceStateProperties> properties(
+ std::unique_ptr<DeviceStateList> device_state_list(new DeviceStateList);
+ std::unique_ptr<api::networking_private::DeviceStateProperties> properties(
new api::networking_private::DeviceStateProperties);
properties->type = api::networking_private::NETWORK_TYPE_WIFI;
properties->state = api::networking_private::DEVICE_STATE_TYPE_ENABLED;
@@ -614,10 +615,11 @@ void NetworkingPrivateLinux::RemoveObserver(
}
void NetworkingPrivateLinux::OnAccessPointsFound(
- scoped_ptr<NetworkMap> network_map,
+ std::unique_ptr<NetworkMap> network_map,
const NetworkListCallback& success_callback,
const FailureCallback& failure_callback) {
- scoped_ptr<base::ListValue> network_list = CopyNetworkMapToList(*network_map);
+ std::unique_ptr<base::ListValue> network_list =
+ CopyNetworkMapToList(*network_map);
// Give ownership to the member variable.
network_map_.swap(network_map);
SendNetworkListChangedEvent(*network_list);
@@ -625,8 +627,9 @@ void NetworkingPrivateLinux::OnAccessPointsFound(
}
void NetworkingPrivateLinux::OnAccessPointsFoundViaScan(
- scoped_ptr<NetworkMap> network_map) {
- scoped_ptr<base::ListValue> network_list = CopyNetworkMapToList(*network_map);
+ std::unique_ptr<NetworkMap> network_map) {
+ std::unique_ptr<base::ListValue> network_list =
+ CopyNetworkMapToList(*network_map);
// Give ownership to the member variable.
network_map_.swap(network_map);
SendNetworkListChangedEvent(*network_list);
@@ -656,7 +659,7 @@ bool NetworkingPrivateLinux::GetNetworkDevices(
networking_private::kNetworkManagerNamespace,
networking_private::kNetworkManagerGetDevicesMethod);
- scoped_ptr<dbus::Response> device_response(
+ std::unique_ptr<dbus::Response> device_response(
network_manager_proxy_->CallMethodAndBlock(
&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT));
@@ -684,7 +687,7 @@ NetworkingPrivateLinux::DeviceType NetworkingPrivateLinux::GetDeviceType(
builder.AppendString(networking_private::kNetworkManagerDeviceNamespace);
builder.AppendString(networking_private::kNetworkManagerDeviceType);
- scoped_ptr<dbus::Response> response(device_proxy->CallMethodAndBlock(
+ std::unique_ptr<dbus::Response> response(device_proxy->CallMethodAndBlock(
&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT));
if (!response) {
@@ -733,7 +736,7 @@ void NetworkingPrivateLinux::GetAllWiFiAccessPoints(bool configured_only,
}
}
-scoped_ptr<dbus::Response> NetworkingPrivateLinux::GetAccessPointProperty(
+std::unique_ptr<dbus::Response> NetworkingPrivateLinux::GetAccessPointProperty(
dbus::ObjectProxy* access_point_proxy,
const std::string& property_name) {
AssertOnDBusThread();
@@ -742,8 +745,9 @@ scoped_ptr<dbus::Response> NetworkingPrivateLinux::GetAccessPointProperty(
dbus::MessageWriter builder(&method_call);
builder.AppendString(networking_private::kNetworkManagerAccessPointNamespace);
builder.AppendString(property_name);
- scoped_ptr<dbus::Response> response = access_point_proxy->CallMethodAndBlock(
- &method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT);
+ std::unique_ptr<dbus::Response> response =
+ access_point_proxy->CallMethodAndBlock(
+ &method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT);
if (!response) {
LOG(ERROR) << "Failed to get property for " << property_name;
}
@@ -752,14 +756,14 @@ scoped_ptr<dbus::Response> NetworkingPrivateLinux::GetAccessPointProperty(
bool NetworkingPrivateLinux::GetAccessPointInfo(
const dbus::ObjectPath& access_point_path,
- const scoped_ptr<base::DictionaryValue>& access_point_info) {
+ const std::unique_ptr<base::DictionaryValue>& access_point_info) {
AssertOnDBusThread();
dbus::ObjectProxy* access_point_proxy = dbus_->GetObjectProxy(
networking_private::kNetworkManagerNamespace, access_point_path);
// Read the SSID. The GUID is derived from the Ssid.
{
- scoped_ptr<dbus::Response> response(GetAccessPointProperty(
+ std::unique_ptr<dbus::Response> response(GetAccessPointProperty(
access_point_proxy, networking_private::kNetworkManagerSsidProperty));
if (!response) {
@@ -791,7 +795,7 @@ bool NetworkingPrivateLinux::GetAccessPointInfo(
// Read signal strength.
{
- scoped_ptr<dbus::Response> response(GetAccessPointProperty(
+ std::unique_ptr<dbus::Response> response(GetAccessPointProperty(
access_point_proxy,
networking_private::kNetworkManagerStrengthProperty));
if (!response) {
@@ -816,7 +820,7 @@ bool NetworkingPrivateLinux::GetAccessPointInfo(
uint32_t wpa_security_flags = 0;
{
- scoped_ptr<dbus::Response> response(GetAccessPointProperty(
+ std::unique_ptr<dbus::Response> response(GetAccessPointProperty(
access_point_proxy,
networking_private::kNetworkManagerWpaFlagsProperty));
if (!response) {
@@ -834,7 +838,7 @@ bool NetworkingPrivateLinux::GetAccessPointInfo(
uint32_t rsn_security_flags = 0;
{
- scoped_ptr<dbus::Response> response(GetAccessPointProperty(
+ std::unique_ptr<dbus::Response> response(GetAccessPointProperty(
access_point_proxy,
networking_private::kNetworkManagerRsnFlagsProperty));
if (!response) {
@@ -872,7 +876,7 @@ bool NetworkingPrivateLinux::AddAccessPointsFromDevice(
dbus::MethodCall method_call(
networking_private::kNetworkManagerWirelessDeviceNamespace,
networking_private::kNetworkManagerGetAccessPointsMethod);
- scoped_ptr<dbus::Response> response(device_proxy->CallMethodAndBlock(
+ std::unique_ptr<dbus::Response> response(device_proxy->CallMethodAndBlock(
&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT));
if (!response) {
@@ -890,7 +894,8 @@ bool NetworkingPrivateLinux::AddAccessPointsFromDevice(
}
for (const auto& access_point_path : access_point_paths) {
- scoped_ptr<base::DictionaryValue> access_point(new base::DictionaryValue);
+ std::unique_ptr<base::DictionaryValue> access_point(
+ new base::DictionaryValue);
if (GetAccessPointInfo(access_point_path, access_point)) {
std::string connection_state =
@@ -920,7 +925,7 @@ bool NetworkingPrivateLinux::AddAccessPointsFromDevice(
void NetworkingPrivateLinux::AddOrUpdateAccessPoint(
NetworkMap* network_map,
const std::string& network_guid,
- scoped_ptr<base::DictionaryValue>& access_point) {
+ std::unique_ptr<base::DictionaryValue>& access_point) {
base::string16 ssid;
std::string connection_state;
int signal_strength;
@@ -992,7 +997,7 @@ bool NetworkingPrivateLinux::GetConnectedAccessPoint(
builder.AppendString(networking_private::kNetworkManagerNamespace);
builder.AppendString(networking_private::kNetworkManagerActiveConnections);
- scoped_ptr<dbus::Response> response(
+ std::unique_ptr<dbus::Response> response(
network_manager_proxy_->CallMethodAndBlock(
&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT));
@@ -1050,7 +1055,7 @@ bool NetworkingPrivateLinux::GetDeviceOfConnection(
networking_private::kNetworkManagerActiveConnectionNamespace);
builder.AppendString("Devices");
- scoped_ptr<dbus::Response> response(connection_proxy->CallMethodAndBlock(
+ std::unique_ptr<dbus::Response> response(connection_proxy->CallMethodAndBlock(
&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT));
if (!response) {
@@ -1098,7 +1103,7 @@ bool NetworkingPrivateLinux::GetAccessPointForConnection(
networking_private::kNetworkManagerActiveConnectionNamespace);
builder.AppendString(networking_private::kNetworkManagerSpecificObject);
- scoped_ptr<dbus::Response> response(connection_proxy->CallMethodAndBlock(
+ std::unique_ptr<dbus::Response> response(connection_proxy->CallMethodAndBlock(
&method_call, dbus::ObjectProxy::TIMEOUT_USE_DEFAULT));
if (!response) {
@@ -1159,7 +1164,7 @@ bool NetworkingPrivateLinux::SetConnectionStateAndPostEvent(
network_iter->second->SetString(kAccessPointInfoConnectionState,
connection_state);
- scoped_ptr<GuidList> changed_networks(new GuidList());
+ std::unique_ptr<GuidList> changed_networks(new GuidList());
changed_networks->push_back(guid);
// Only add a second network if it exists and it is not the same as the
@@ -1189,7 +1194,7 @@ void NetworkingPrivateLinux::OnNetworkListChangedEventOnUIThread(
}
void NetworkingPrivateLinux::PostOnNetworksChangedToUIThread(
- scoped_ptr<GuidList> guid_list) {
+ std::unique_ptr<GuidList> guid_list) {
AssertOnDBusThread();
content::BrowserThread::PostTask(
@@ -1199,7 +1204,7 @@ void NetworkingPrivateLinux::PostOnNetworksChangedToUIThread(
}
void NetworkingPrivateLinux::OnNetworksChangedEventTask(
- scoped_ptr<GuidList> guid_list) {
+ std::unique_ptr<GuidList> guid_list) {
DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
OnNetworksChangedEventOnUIThread(*guid_list);
}

Powered by Google App Engine
This is Rietveld 408576698