Remove the WEB_AUDIO compile time flag

Remove the WEB_AUDIO compile time flag

Web audio already has a runtime feature flag,
so the WEB_AUDIO compile-time flag wouldn't be needed.
Per the comment in https://codereview.chromium.org/604753003/#msg8,
it looks safe to remove the compile-time flag.

Web audio is the last feature that uses a compile-time flag.
Once we remove WEB_AUDIO, we can remove a lot of code to support
compile-time features from the IDL comipler.

BUG=417628
TBR=jochen@chromium.org

Committed: https://crrev.com/e7fc592f19c6ffde1296ff01482013a0dd68a977
Cr-Commit-Position: refs/heads/master@{#368554}

[haraken, 2016-01-05 11:59:07]

haraken@chromium.org changed reviewers:
+ kbr@chromium.org, rtoy@chromium.org

[haraken, 2016-01-05 11:59:09]

PTAL. This is a rebase version of https://codereview.chromium.org/604753003/.

In https://codereview.chromium.org/604753003/#msg4, RashmiVijay was saying that
this CL would need a clobber build, but I don't think it's needed. Since this CL
is touching IDL files, auto-generated binding files will be just re-generated.

[Raymond Toy, 2016-01-05 19:00:44]

lgtm for modules/webaudio and platform/audio.

Thanks for doing this!

[Ken Russell (switch to Gerrit), 2016-01-05 22:18:07]

lgtm if it compiles and doesn't require a clobber build or landmine. Looks like
there are still issues on some platforms.

[haraken, 2016-01-06 12:13:23]

Yeah, there are still issues on some platforms. It looks like that something is
wrong with the dependency resolution of the IDL compiler. Generated bindings
that need to be rebuilt are not rebuilt. I'm looking.

[haraken, 2016-01-06 12:14:36]

haraken@chromium.org changed reviewers:
+ tasak@google.com, tzik@chromium.org

[haraken, 2016-01-06 12:14:37]

+tasak, +tzik FYI.

There are still some issues in a dependency resolution of generated bindings.

[tzik, 2016-01-08 07:58:29]

On 2016/01/06 12:14:37, haraken wrote:
> +tasak, +tzik FYI.
> 
> There are still some issues in a dependency resolution of generated bindings.

V8AudioContext.o is not rebuilt in the log:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

And even the ninja doesn't have a build statement for it, according to below:
ninja -C out/Release -t query gen/blink/bindings/modules/v8/V8AudioContext.cpp

[haraken, 2016-01-08 08:01:22]

On 2016/01/08 07:58:29, tzik wrote:
> On 2016/01/06 12:14:37, haraken wrote:
> > +tasak, +tzik FYI.
> > 
> > There are still some issues in a dependency resolution of generated
bindings.
> 
> V8AudioContext.o is not rebuilt in the log:
>
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...
> 
> And even the ninja doesn't have a build statement for it, according to below:
> ninja -C out/Release -t query gen/blink/bindings/modules/v8/V8AudioContext.cpp

Yeah, that's the problem.

I tried to fix the dependency problem by simulating your CL
(https://codereview.chromium.org/1544373002/) and made a change to
code_generator_v8.py (see the patch set), but it seems it doesn't work :/

[tzik, 2016-01-08 08:51:28]

Ah....
Now I understand how these V8*.cpp files are compiled.
V8GeneratedBindingModules*.cpp includes these ".cpp"s and compiles them as a
bundle.
That's why the query command doesn't show a .o file.

[haraken, 2016-01-08 09:10:34]

On 2016/01/08 08:51:28, tzik wrote:
> Ah....
> Now I understand how these V8*.cpp files are compiled.
> V8GeneratedBindingModules*.cpp includes these ".cpp"s and compiles them as a
> bundle.
> That's why the query command doesn't show a .o file.

Ah, good point. So does it mean that the generated files are successfully
recompiled?

[tzik, 2016-01-10 17:14:06]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-01-10 17:14:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557363002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557363002/40001

[commit-bot: I haz the power, 2016-01-11 09:06:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 09:06:13]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-01-11 09:11:15]

On 2016/01/11 09:06:13, commit-bot: I haz the power wrote:
> Dry run: This issue passed the CQ dry run.

Thank you very much!!!

[haraken, 2016-01-11 09:11:25]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-01-11 09:11:26]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org,
rtoy@chromium.org
Link to the patchset: https://codereview.chromium.org/1557363002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2016-01-11 09:11:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557363002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557363002/40001

[commit-bot: I haz the power, 2016-01-11 09:24:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-11 09:24:09]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[haraken, 2016-01-11 09:29:55]

haraken@chromium.org changed reviewers:
+ jochen@chromium.org

[haraken, 2016-01-11 09:29:56]

TBRing jochen for Source/config.gni.

[haraken, 2016-01-11 09:30:15]

Description was changed from

==========
Remove the WEB_AUDIO compile time flag

Web audio already has a runtime feature flag,
so the WEB_AUDIO compile-time flag wouldn't be needed.
Per the comment in https://codereview.chromium.org/604753003/#msg8,
it looks safe to remove the compile-time flag.

Web audio is the last feature that uses a compile-time flag.
Once we remove WEB_AUDIO, we can remove a lot of code to support
compile-time features from the IDL comipler.

BUG=417628
==========

to

==========
Remove the WEB_AUDIO compile time flag

Web audio already has a runtime feature flag,
so the WEB_AUDIO compile-time flag wouldn't be needed.
Per the comment in https://codereview.chromium.org/604753003/#msg8,
it looks safe to remove the compile-time flag.

Web audio is the last feature that uses a compile-time flag.
Once we remove WEB_AUDIO, we can remove a lot of code to support
compile-time features from the IDL comipler.

BUG=417628
TBR=jochen@chromium.org
==========

[haraken, 2016-01-11 09:30:26]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2016-01-11 09:30:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1557363002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1557363002/40001

[commit-bot: I haz the power, 2016-01-11 10:20:11]

Description was changed from

==========
Remove the WEB_AUDIO compile time flag

Web audio already has a runtime feature flag,
so the WEB_AUDIO compile-time flag wouldn't be needed.
Per the comment in https://codereview.chromium.org/604753003/#msg8,
it looks safe to remove the compile-time flag.

Web audio is the last feature that uses a compile-time flag.
Once we remove WEB_AUDIO, we can remove a lot of code to support
compile-time features from the IDL comipler.

BUG=417628
TBR=jochen@chromium.org
==========

to

==========
Remove the WEB_AUDIO compile time flag

Web audio already has a runtime feature flag,
so the WEB_AUDIO compile-time flag wouldn't be needed.
Per the comment in https://codereview.chromium.org/604753003/#msg8,
it looks safe to remove the compile-time flag.

Web audio is the last feature that uses a compile-time flag.
Once we remove WEB_AUDIO, we can remove a lot of code to support
compile-time features from the IDL comipler.

BUG=417628
TBR=jochen@chromium.org
==========

[commit-bot: I haz the power, 2016-01-11 10:20:12]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-11 10:21:40]

Description was changed from

==========
Remove the WEB_AUDIO compile time flag

Web audio already has a runtime feature flag,
so the WEB_AUDIO compile-time flag wouldn't be needed.
Per the comment in https://codereview.chromium.org/604753003/#msg8,
it looks safe to remove the compile-time flag.

Web audio is the last feature that uses a compile-time flag.
Once we remove WEB_AUDIO, we can remove a lot of code to support
compile-time features from the IDL comipler.

BUG=417628
TBR=jochen@chromium.org
==========

to

==========
Remove the WEB_AUDIO compile time flag

Web audio already has a runtime feature flag,
so the WEB_AUDIO compile-time flag wouldn't be needed.
Per the comment in https://codereview.chromium.org/604753003/#msg8,
it looks safe to remove the compile-time flag.

Web audio is the last feature that uses a compile-time flag.
Once we remove WEB_AUDIO, we can remove a lot of code to support
compile-time features from the IDL comipler.

BUG=417628
TBR=jochen@chromium.org

Committed: https://crrev.com/e7fc592f19c6ffde1296ff01482013a0dd68a977
Cr-Commit-Position: refs/heads/master@{#368554}
==========

[commit-bot: I haz the power, 2016-01-11 10:21:41]

Patchset 3 (id:??) landed as
https://crrev.com/e7fc592f19c6ffde1296ff01482013a0dd68a977
Cr-Commit-Position: refs/heads/master@{#368554}