Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1425013003: Remove GrGLProcessor and create GrGLSLTextureSampler class. (Closed)

Created:
5 years, 1 month ago by egdaniel
Modified:
5 years, 1 month ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove GrGLProcessor and create GrGLSLTextureSampler class. Part ??? of separating glsl and gl BUG=skia: Committed: https://skia.googlesource.com/skia/+/7dc4bd06fca73a97dcf3ad4a7425597160f1edfc

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : remove grglprocessor from gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -135 lines) Patch
M gm/dcshader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/gpu.gypi View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/core/SkLightingShader.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/effects/SkBlurMaskFilter.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/GrOvalRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrPathProcessor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/batches/GrAAConvexPathRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/batches/GrAALinearizingConvexPathRenderer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/effects/GrTextureDomain.h View 5 chunks +13 lines, -11 lines 0 comments Download
M src/gpu/effects/GrTextureDomain.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLFragmentProcessor.h View 1 5 chunks +7 lines, -6 lines 0 comments Download
M src/gpu/gl/GrGLFragmentProcessor.cpp View 1 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/gl/GrGLGeometryProcessor.cpp View 3 chunks +3 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGLPrimitiveProcessor.h View 1 3 chunks +7 lines, -6 lines 0 comments Download
D src/gpu/gl/GrGLProcessor.h View 1 chunk +0 lines, -69 lines 0 comments Download
M src/gpu/gl/GrGLProgram.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/gl/GrGLXferProcessor.h View 3 chunks +2 lines, -4 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.h View 3 chunks +4 lines, -3 lines 0 comments Download
M src/gpu/gl/builders/GrGLFragmentShaderBuilder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.h View 2 chunks +2 lines, -1 line 0 comments Download
M src/gpu/gl/builders/GrGLProgramBuilder.cpp View 6 chunks +6 lines, -5 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.h View 2 chunks +9 lines, -10 lines 0 comments Download
M src/gpu/gl/builders/GrGLShaderBuilder.cpp View 3 chunks +4 lines, -3 lines 0 comments Download
A src/gpu/glsl/GrGLSLProcessorTypes.h View 1 chunk +20 lines, -0 lines 0 comments Download
M src/gpu/glsl/GrGLSLProgramDataManager.h View 1 chunk +2 lines, -0 lines 0 comments Download
A src/gpu/glsl/GrGLSLTextureSampler.h View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
egdaniel
5 years, 1 month ago (2015-10-28 19:56:18 UTC) #2
joshualitt
On 2015/10/28 19:56:18, egdaniel wrote: lgtm
5 years, 1 month ago (2015-10-28 20:22:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425013003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425013003/20001
5 years, 1 month ago (2015-10-29 14:31:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86_64-Debug-Trybot/builds/4013)
5 years, 1 month ago (2015-10-29 14:33:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1425013003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1425013003/40001
5 years, 1 month ago (2015-10-29 14:45:42 UTC) #10
commit-bot: I haz the power
5 years, 1 month ago (2015-10-29 14:57:04 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/7dc4bd06fca73a97dcf3ad4a7425597160f1edfc

Powered by Google App Engine
This is Rietveld 408576698