Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1167423002: Use V8 Maybe APIs in extensions/renderer (Closed)

Created:
5 years, 6 months ago by bashi
Modified:
4 years, 3 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use V8 Maybe APIs in extensions/renderer Replacing DEPRECATE_SOON APIs. BUG=479065

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+629 lines, -342 lines) Patch
M extensions/extensions.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M extensions/extensions.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M extensions/renderer/activity_log_converter_strategy.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M extensions/renderer/api_activity_logger.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M extensions/renderer/app_runtime_custom_bindings.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M extensions/renderer/app_window_custom_bindings.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/binding_generating_native_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/binding_generating_native_handler.cc View 2 chunks +48 lines, -21 lines 0 comments Download
M extensions/renderer/blob_native_handler.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M extensions/renderer/console.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M extensions/renderer/dispatcher.cc View 5 chunks +25 lines, -16 lines 0 comments Download
M extensions/renderer/event_bindings.cc View 6 chunks +23 lines, -17 lines 0 comments Download
M extensions/renderer/file_system_natives.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M extensions/renderer/guest_view/extensions_guest_view_container.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc View 8 chunks +8 lines, -8 lines 0 comments Download
M extensions/renderer/guest_view/mime_handler_view/mime_handler_view_container.cc View 2 chunks +10 lines, -3 lines 0 comments Download
M extensions/renderer/i18n_custom_bindings.cc View 2 chunks +13 lines, -6 lines 0 comments Download
M extensions/renderer/logging_native_handler.cc View 1 chunk +6 lines, -1 line 0 comments Download
M extensions/renderer/messaging_bindings.cc View 11 chunks +32 lines, -30 lines 0 comments Download
M extensions/renderer/module_system.h View 3 chunks +5 lines, -3 lines 0 comments Download
M extensions/renderer/module_system.cc View 30 chunks +149 lines, -89 lines 0 comments Download
M extensions/renderer/module_system_test.cc View 1 chunk +3 lines, -1 line 0 comments Download
M extensions/renderer/module_system_unittest.cc View 5 chunks +22 lines, -11 lines 0 comments Download
M extensions/renderer/native_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/object_backed_native_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/object_backed_native_handler.cc View 5 chunks +15 lines, -12 lines 0 comments Download
M extensions/renderer/process_info_native_handler.cc View 3 chunks +10 lines, -5 lines 0 comments Download
M extensions/renderer/render_view_observer_natives.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/resource_bundle_source_map.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M extensions/renderer/runtime_custom_bindings.cc View 3 chunks +6 lines, -3 lines 0 comments Download
M extensions/renderer/safe_builtins.cc View 4 chunks +16 lines, -12 lines 0 comments Download
M extensions/renderer/script_context.cc View 5 chunks +17 lines, -7 lines 0 comments Download
M extensions/renderer/send_request_natives.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M extensions/renderer/set_icon_natives.cc View 7 chunks +81 lines, -42 lines 0 comments Download
M extensions/renderer/utils_native_handler.cc View 3 chunks +13 lines, -7 lines 0 comments Download
M extensions/renderer/v8_context_native_handler.cc View 3 chunks +16 lines, -9 lines 0 comments Download
A extensions/renderer/v8_maybe_helpers.h View 1 chunk +46 lines, -0 lines 0 comments Download
M extensions/renderer/v8_schema_registry.cc View 2 chunks +4 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bashi
PTAL? Context: https://groups.google.com/forum/#!searchin/v8-users/maybe/v8-users/gQVpp1HmbqM/BEtPgyOzQv4J
5 years, 6 months ago (2015-06-09 08:22:12 UTC) #3
not at google - send to devlin
I'll get to this as soon as possible, but I notice it's quite a large ...
5 years, 6 months ago (2015-06-09 20:08:20 UTC) #4
not at google - send to devlin
in particular it would be good to do some of the complex classes like module ...
5 years, 6 months ago (2015-06-09 20:28:41 UTC) #5
bashi
5 years, 6 months ago (2015-06-09 22:38:03 UTC) #6
On 2015/06/09 20:28:41, kalman wrote:
> in particular it would be good to do some of the complex classes like module
> system and messaging in completely separate CLs because they're complex.

Thank you for taking a look! I'll create separate CLs (I'm ooo several days so
it may take time).

Powered by Google App Engine
This is Rietveld 408576698