extensions/renderer/render_view_observer_natives.cc - Issue 1167423002: Use V8 Maybe APIs in extensions/renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/render_view_observer_natives.cc

Issue 1167423002: Use V8 Maybe APIs in extensions/renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/render_view_observer_natives.cc

diff --git a/extensions/renderer/render_view_observer_natives.cc b/extensions/renderer/render_view_observer_natives.cc

index 0140ec41d6e8fcab4c10d29b6a686445637d3f57..f28b82f0ba5494dc9e13a4c936ccb1c6bfc279dd 100644

--- a/extensions/renderer/render_view_observer_natives.cc

+++ b/extensions/renderer/render_view_observer_natives.cc

@@ -63,7 +63,7 @@ void RenderViewObserverNatives::OnDocumentElementCreated(

CHECK(args[0]->IsInt32());

CHECK(args[1]->IsFunction());

- int view_id = args[0]->Int32Value();

+ int view_id = args[0].As<v8::Int32>()->Value();

content::RenderView* view = content::RenderView::FromRoutingID(view_id);

if (!view) {