Use V8 Maybe APIs in extensions/renderer

extensions/renderer/file_system_natives.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/file_system_natives.h"
 
 #include <string>
 
 #include "extensions/common/constants.h"
 #include "extensions/renderer/script_context.h"
+#include "extensions/renderer/v8_maybe_helpers.h"
 #include "storage/common/fileapi/file_system_types.h"
 #include "storage/common/fileapi/file_system_util.h"
 #include "third_party/WebKit/public/platform/WebString.h"
 #include "third_party/WebKit/public/web/WebDOMError.h"
 #include "third_party/WebKit/public/web/WebDOMFileSystem.h"
 #include "third_party/WebKit/public/web/WebLocalFrame.h"
 
 namespace extensions {
 
 FileSystemNatives::FileSystemNatives(ScriptContext* context)
@@ skipping 63 matching lines @@
   DCHECK(args[2]->IsString());
   DCHECK(args[3]->IsString());
   std::string file_system_name(*v8::String::Utf8Value(args[1]));
   GURL file_system_root_url(*v8::String::Utf8Value(args[2]));
   std::string file_path_string(*v8::String::Utf8Value(args[3]));
   base::FilePath file_path = base::FilePath::FromUTF8Unsafe(file_path_string);
   DCHECK(storage::VirtualPath::IsAbsolute(file_path.value()));
 
   DCHECK(args[4]->IsBoolean());
   blink::WebDOMFileSystem::EntryType entry_type =
-      args[4]->BooleanValue() ? blink::WebDOMFileSystem::EntryTypeDirectory
-                              : blink::WebDOMFileSystem::EntryTypeFile;
+      args[4].As<v8::Boolean>()->Value()
+          ? blink::WebDOMFileSystem::EntryTypeDirectory
+          : blink::WebDOMFileSystem::EntryTypeFile;
 
   blink::WebLocalFrame* webframe =
       blink::WebLocalFrame::frameForContext(context()->v8_context());
   DCHECK(webframe);
   args.GetReturnValue().Set(
       blink::WebDOMFileSystem::create(
           webframe,
           type,
           blink::WebString::fromUTF8(file_system_name),
           file_system_root_url)
           .createV8Entry(blink::WebString::fromUTF8(file_path_string),
                          entry_type,
                          args.Holder(),
                          args.GetIsolate()));
 }
 
 void FileSystemNatives::CrackIsolatedFileSystemName(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   DCHECK_EQ(args.Length(), 1);
   DCHECK(args[0]->IsString());
   std::string filesystem_name = *v8::String::Utf8Value(args[0]);
   std::string filesystem_id;
   if (!storage::CrackIsolatedFileSystemName(filesystem_name, &filesystem_id))
     return;
+  if (filesystem_id.size() >= v8::String::kMaxLength)
+    return;
 
-  args.GetReturnValue().Set(v8::String::NewFromUtf8(args.GetIsolate(),
-                                                    filesystem_id.c_str(),
-                                                    v8::String::kNormalString,
-                                                    filesystem_id.size()));
+  args.GetReturnValue().Set(
+      ToV8String(args.GetIsolate(), filesystem_id.c_str()));
 }
 
 void FileSystemNatives::GetDOMError(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   if (args.Length() != 2) {
     NOTREACHED();
     return;
   }
   if (!args[0]->IsString()) {
     NOTREACHED();
@@ skipping 12 matching lines @@
   std::string message(*v8::String::Utf8Value(args[1]));
   // message is optional hence empty is fine.
 
   blink::WebDOMError dom_error = blink::WebDOMError::create(
       blink::WebString::fromUTF8(name), blink::WebString::fromUTF8(message));
   args.GetReturnValue().Set(
       dom_error.toV8Value(args.Holder(), args.GetIsolate()));
 }
 
 }  // namespace extensions