extensions/renderer/binding_generating_native_handler.h - Issue 1167423002: Use V8 Maybe APIs in extensions/renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/binding_generating_native_handler.h

Issue 1167423002: Use V8 Maybe APIs in extensions/renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/binding_generating_native_handler.h

diff --git a/extensions/renderer/binding_generating_native_handler.h b/extensions/renderer/binding_generating_native_handler.h

index 9a8883347a8efa96c875b6667c16fb1d549d3cc3..c977a886b6aab9aca4f75edbac502f30c4f79da6 100644

--- a/extensions/renderer/binding_generating_native_handler.h

+++ b/extensions/renderer/binding_generating_native_handler.h

@@ -25,7 +25,7 @@ class BindingGeneratingNativeHandler : public NativeHandler {

const std::string& api_name,

const std::string& bind_to);

- v8::Local<v8::Object> NewInstance() override;

+ v8::MaybeLocal<v8::Object> NewInstance() override;

private:

ModuleSystem* module_system_;