Use V8 Maybe APIs in extensions/renderer

extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/guest_view/guest_view_internal_custom_bindings.h"
 
 #include <string>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 90 matching lines @@
   CHECK(args.Length() >= 3 && args.Length() <= 4);
   // Element Instance ID.
   CHECK(args[0]->IsInt32());
   // Guest Instance ID.
   CHECK(args[1]->IsInt32());
   // Attach Parameters.
   CHECK(args[2]->IsObject());
   // Optional Callback Function.
   CHECK(args.Length() < 4 || args[3]->IsFunction());
 
-  int element_instance_id = args[0]->Int32Value();
+  int element_instance_id = args[0].As<v8::Int32>()->Value();
   // An element instance ID uniquely identifies a GuestViewContainer.
   auto guest_view_container =
       guest_view::GuestViewContainer::FromID(element_instance_id);
 
   // TODO(fsamuel): Should we be reporting an error if the element instance ID
   // is invalid?
   if (!guest_view_container)
     return;
 
-  int guest_instance_id = args[1]->Int32Value();
+  int guest_instance_id = args[1].As<v8::Int32>()->Value();
 
   scoped_ptr<base::DictionaryValue> params;
   {
     scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());
     scoped_ptr<base::Value> params_as_value(
         converter->FromV8Value(args[2], context()->v8_context()));
     CHECK(params_as_value->IsType(base::Value::TYPE_DICTIONARY));
     params.reset(
         static_cast<base::DictionaryValue*>(params_as_value.release()));
   }
@@ skipping 15 matching lines @@
 
 void GuestViewInternalCustomBindings::DetachGuest(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   // Allow for an optional callback parameter.
   CHECK(args.Length() >= 1 && args.Length() <= 2);
   // Element Instance ID.
   CHECK(args[0]->IsInt32());
   // Optional Callback Function.
   CHECK(args.Length() < 2 || args[1]->IsFunction());
 
-  int element_instance_id = args[0]->Int32Value();
+  int element_instance_id = args[0].As<v8::Int32>()->Value();
   // An element instance ID uniquely identifies a GuestViewContainer.
   auto guest_view_container =
       guest_view::GuestViewContainer::FromID(element_instance_id);
 
   // TODO(fsamuel): Should we be reporting an error if the element instance ID
   // is invalid?
   if (!guest_view_container)
     return;
 
   linked_ptr<guest_view::GuestViewRequest> request(
@@ skipping 11 matching lines @@
   // Default to returning null.
   args.GetReturnValue().SetNull();
 
   if (args.Length() != 1)
     return;
 
   // The routing ID for the RenderView.
   if (!args[0]->IsInt32())
     return;
 
-  int view_id = args[0]->Int32Value();
+  int view_id = args[0].As<v8::Int32>()->Value();
   if (view_id == MSG_ROUTING_NONE)
     return;
 
   content::RenderView* view = content::RenderView::FromRoutingID(view_id);
   if (!view)
     return;
 
   blink::WebFrame* frame = view->GetWebView()->mainFrame();
   v8::Local<v8::Value> window = frame->mainWorldScriptContext()->Global();
   args.GetReturnValue().Set(window);
 }
 
 void GuestViewInternalCustomBindings::GetViewFromID(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   // Default to returning null.
   args.GetReturnValue().SetNull();
   // There is one argument.
   CHECK(args.Length() == 1);
   // The view ID.
   CHECK(args[0]->IsInt32());
-  int view_id = args[0]->Int32Value();
+  int view_id = args[0].As<v8::Int32>()->Value();
 
   ViewMap& view_map = weak_view_map.Get();
   auto map_entry = view_map.find(view_id);
   if (map_entry == view_map.end())
     return;
 
   auto return_object = v8::Handle<v8::Object>::New(args.GetIsolate(),
                                                    *map_entry->second);
   args.GetReturnValue().Set(return_object);
 }
 
 void GuestViewInternalCustomBindings::RegisterDestructionCallback(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   // There are two parameters.
   CHECK(args.Length() == 2);
   // Element Instance ID.
   CHECK(args[0]->IsInt32());
   // Callback function.
   CHECK(args[1]->IsFunction());
 
-  int element_instance_id = args[0]->Int32Value();
+  int element_instance_id = args[0].As<v8::Int32>()->Value();
   // An element instance ID uniquely identifies a ExtensionsGuestViewContainer
   // within a RenderView.
   auto guest_view_container = static_cast<ExtensionsGuestViewContainer*>(
       guest_view::GuestViewContainer::FromID(element_instance_id));
   if (!guest_view_container)
     return;
 
   guest_view_container->RegisterDestructionCallback(args[1].As<v8::Function>(),
                                                     args.GetIsolate());
 
   args.GetReturnValue().Set(v8::Boolean::New(context()->isolate(), true));
 }
 
 void GuestViewInternalCustomBindings::RegisterElementResizeCallback(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   // There are two parameters.
   CHECK(args.Length() == 2);
   // Element Instance ID.
   CHECK(args[0]->IsInt32());
   // Callback function.
   CHECK(args[1]->IsFunction());
 
-  int element_instance_id = args[0]->Int32Value();
+  int element_instance_id = args[0].As<v8::Int32>()->Value();
   // An element instance ID uniquely identifies a ExtensionsGuestViewContainer
   // within a RenderView.
   auto guest_view_container = static_cast<ExtensionsGuestViewContainer*>(
       guest_view::GuestViewContainer::FromID(element_instance_id));
   if (!guest_view_container)
     return;
 
   guest_view_container->RegisterElementResizeCallback(
       args[1].As<v8::Function>(), args.GetIsolate());
 
   args.GetReturnValue().Set(v8::Boolean::New(context()->isolate(), true));
 }
 
 void GuestViewInternalCustomBindings::RegisterView(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   // There are two parameters.
   CHECK(args.Length() == 2);
   // View Instance ID.
   CHECK(args[0]->IsInt32());
   // View element.
   CHECK(args[1]->IsObject());
 
   // A reference to the view object is stored in |weak_view_map| using its view
   // ID as the key. The reference is made weak so that it will not extend the
   // lifetime of the object.
-  int view_id = args[0]->Int32Value();
+  int view_id = args[0].As<v8::Int32>()->Value();
   auto object =
       new v8::Global<v8::Object>(args.GetIsolate(), args[1].As<v8::Object>());
   weak_view_map.Get().insert(std::make_pair(view_id, object));
 
   // The view_id is given to the SetWeak callback so that that view's entry in
   // |weak_view_map| can be cleared when the view object is garbage collected.
   object->SetWeak(new int(view_id),
                   &GuestViewInternalCustomBindings::ResetMapEntry,
                   v8::WeakCallbackType::kParameter);
 }
 
 void GuestViewInternalCustomBindings::RunWithGesture(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   // Gesture is required to request fullscreen.
   blink::WebScopedUserGesture user_gesture;
   CHECK_EQ(args.Length(), 1);
   CHECK(args[0]->IsFunction());
   v8::Local<v8::Value> no_args;
   context()->CallFunction(v8::Local<v8::Function>::Cast(args[0]), 0, &no_args);
 }
 
 }  // namespace extensions