Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1177)

Unified Diff: extensions/renderer/guest_view/extensions_guest_view_container.cc

Issue 1167423002: Use V8 Maybe APIs in extensions/renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/renderer/guest_view/extensions_guest_view_container.cc
diff --git a/extensions/renderer/guest_view/extensions_guest_view_container.cc b/extensions/renderer/guest_view/extensions_guest_view_container.cc
index 1bd857543ca82bc60eeef524e771bd4620b027b9..a04e5bc95968dde6a0b2cd8881c104327075d63a 100644
--- a/extensions/renderer/guest_view/extensions_guest_view_container.cc
+++ b/extensions/renderer/guest_view/extensions_guest_view_container.cc
@@ -31,7 +31,9 @@ ExtensionsGuestViewContainer::~ExtensionsGuestViewContainer() {
v8::Context::Scope context_scope(context);
blink::WebScopedMicrotaskSuppression suppression;
- callback->Call(context->Global(), 0 /* argc */, nullptr);
+ auto maybe =
+ callback->Call(context, context->Global(), 0 /* argc */, nullptr);
+ DCHECK(!maybe.IsEmpty());
}
}
@@ -77,7 +79,8 @@ void ExtensionsGuestViewContainer::CallElementResizeCallback(
v8::Context::Scope context_scope(context);
blink::WebScopedMicrotaskSuppression suppression;
- callback->Call(context->Global(), argc, argv);
+ auto maybe = callback->Call(context, context->Global(), argc, argv);
+ DCHECK(!maybe.IsEmpty());
}
} // namespace extensions
« no previous file with comments | « extensions/renderer/file_system_natives.cc ('k') | extensions/renderer/guest_view/guest_view_internal_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698