extensions/renderer/app_window_custom_bindings.cc - Issue 1167423002: Use V8 Maybe APIs in extensions/renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/app_window_custom_bindings.cc

Issue 1167423002: Use V8 Maybe APIs in extensions/renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/app_window_custom_bindings.cc

diff --git a/extensions/renderer/app_window_custom_bindings.cc b/extensions/renderer/app_window_custom_bindings.cc

index b3907e0eda42c7a6a8d67a3cc97c63d6aaf72f08..d756e539f207fcaad4139038aaf9859aec39bc19 100644

--- a/extensions/renderer/app_window_custom_bindings.cc

+++ b/extensions/renderer/app_window_custom_bindings.cc

@@ -75,9 +75,9 @@ void AppWindowCustomBindings::GetView(

if (!args[1]->IsBoolean())

return;

- int view_id = args[0]->Int32Value();

+ int view_id = args[0].As<v8::Int32>()->Value();

- bool inject_titlebar = args[1]->BooleanValue();

+ bool inject_titlebar = args[1].As<v8::Boolean>()->Value();

if (view_id == MSG_ROUTING_NONE)

return;