Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Side by Side Diff: extensions/renderer/app_runtime_custom_bindings.cc

Issue 1167423002: Use V8 Maybe APIs in extensions/renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/renderer/app_runtime_custom_bindings.h" 5 #include "extensions/renderer/app_runtime_custom_bindings.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/strings/string_number_conversions.h" 8 #include "base/strings/string_number_conversions.h"
9 #include "extensions/renderer/v8_maybe_helpers.h"
9 #include "third_party/WebKit/public/platform/WebCString.h" 10 #include "third_party/WebKit/public/platform/WebCString.h"
10 #include "third_party/WebKit/public/platform/WebString.h" 11 #include "third_party/WebKit/public/platform/WebString.h"
11 #include "third_party/WebKit/public/web/WebBlob.h" 12 #include "third_party/WebKit/public/web/WebBlob.h"
12 #include "third_party/WebKit/public/web/WebSerializedScriptValue.h" 13 #include "third_party/WebKit/public/web/WebSerializedScriptValue.h"
13 14
14 using blink::WebBlob; 15 using blink::WebBlob;
15 using blink::WebSerializedScriptValue; 16 using blink::WebSerializedScriptValue;
16 using blink::WebString; 17 using blink::WebString;
17 18
18 namespace { 19 namespace {
19 20
20 void DeserializeString(const v8::FunctionCallbackInfo<v8::Value>& args) { 21 void DeserializeString(const v8::FunctionCallbackInfo<v8::Value>& args) {
21 DCHECK(args.Length() == 1); 22 DCHECK(args.Length() == 1);
22 DCHECK(args[0]->IsString()); 23 DCHECK(args[0]->IsString());
23 24
24 std::string data_v8(*v8::String::Utf8Value(args[0])); 25 std::string data_v8(*v8::String::Utf8Value(args[0]));
25 WebString data_webstring = WebString::fromUTF8(data_v8); 26 WebString data_webstring = WebString::fromUTF8(data_v8);
26 WebSerializedScriptValue serialized = 27 WebSerializedScriptValue serialized =
27 WebSerializedScriptValue::fromString(data_webstring); 28 WebSerializedScriptValue::fromString(data_webstring);
28 args.GetReturnValue().Set(serialized.deserialize()); 29 args.GetReturnValue().Set(serialized.deserialize());
29 } 30 }
30 31
31 void SerializeToString(const v8::FunctionCallbackInfo<v8::Value>& args) { 32 void SerializeToString(const v8::FunctionCallbackInfo<v8::Value>& args) {
32 DCHECK(args.Length() == 1); 33 DCHECK(args.Length() == 1);
33 WebSerializedScriptValue data = WebSerializedScriptValue::serialize(args[0]); 34 WebSerializedScriptValue data = WebSerializedScriptValue::serialize(args[0]);
34 WebString data_webstring = data.toString(); 35 WebString data_webstring = data.toString();
35 36
36 std::string v = std::string(data_webstring.utf8()); 37 std::string v = std::string(data_webstring.utf8());
37 args.GetReturnValue().Set( 38 if (v.size() >= v8::String::kMaxLength)
38 v8::String::NewFromUtf8(args.GetIsolate(), v.c_str())); 39 return;
40 args.GetReturnValue().Set(extensions::ToV8String(args.GetIsolate(),
41 v.c_str()));
39 } 42 }
40 43
41 void CreateBlob(const v8::FunctionCallbackInfo<v8::Value>& args) { 44 void CreateBlob(const v8::FunctionCallbackInfo<v8::Value>& args) {
42 DCHECK(args.Length() == 2); 45 DCHECK(args.Length() == 2);
43 DCHECK(args[0]->IsString()); 46 DCHECK(args[0]->IsString());
44 DCHECK(args[1]->IsNumber()); 47 DCHECK(args[1]->IsNumber());
45 48
46 std::string blob_file_path(*v8::String::Utf8Value(args[0])); 49 std::string blob_file_path(*v8::String::Utf8Value(args[0]));
47 std::string blob_length_string(*v8::String::Utf8Value(args[1])); 50 std::string blob_length_string(*v8::String::Utf8Value(args[1]));
48 int64 blob_length = 0; 51 int64 blob_length = 0;
49 DCHECK(base::StringToInt64(blob_length_string, &blob_length)); 52 DCHECK(base::StringToInt64(blob_length_string, &blob_length));
50 blink::WebBlob web_blob = 53 blink::WebBlob web_blob =
51 WebBlob::createFromFile(WebString::fromUTF8(blob_file_path), blob_length); 54 WebBlob::createFromFile(WebString::fromUTF8(blob_file_path), blob_length);
52 args.GetReturnValue().Set( 55 args.GetReturnValue().Set(
53 web_blob.toV8Value(args.Holder(), args.GetIsolate())); 56 web_blob.toV8Value(args.Holder(), args.GetIsolate()));
54 } 57 }
55 58
56 } // namespace 59 } // namespace
57 60
58 namespace extensions { 61 namespace extensions {
59 62
60 AppRuntimeCustomBindings::AppRuntimeCustomBindings(ScriptContext* context) 63 AppRuntimeCustomBindings::AppRuntimeCustomBindings(ScriptContext* context)
61 : ObjectBackedNativeHandler(context) { 64 : ObjectBackedNativeHandler(context) {
62 RouteFunction("DeserializeString", base::Bind(&DeserializeString)); 65 RouteFunction("DeserializeString", base::Bind(&DeserializeString));
63 RouteFunction("SerializeToString", base::Bind(&SerializeToString)); 66 RouteFunction("SerializeToString", base::Bind(&SerializeToString));
64 RouteFunction("CreateBlob", base::Bind(&CreateBlob)); 67 RouteFunction("CreateBlob", base::Bind(&CreateBlob));
65 } 68 }
66 69
67 } // namespace extensions 70 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/renderer/api_activity_logger.cc ('k') | extensions/renderer/app_window_custom_bindings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698