Use V8 Maybe APIs in extensions/renderer

extensions/renderer/runtime_custom_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/runtime_custom_bindings.h"
 
 #include "base/bind.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/values.h"
 #include "content/public/child/v8_value_converter.h"
@@ skipping 51 matching lines @@
   // For messaging APIs, hosted apps should be considered a web page so hide
   // its extension ID.
   const Extension* extension = context()->extension();
   if (extension && !extension->is_hosted_app())
     info.source_id = extension->id();
 
   info.target_id = *v8::String::Utf8Value(args[0]);
   info.source_url = context()->GetURL();
   std::string channel_name = *v8::String::Utf8Value(args[1]);
   bool include_tls_channel_id =
-      args.Length() > 2 ? args[2]->BooleanValue() : false;
+      args.Length() > 2 ? args[2].As<v8::Boolean>()->Value() : false;
   int port_id = -1;
   renderframe->Send(new ExtensionHostMsg_OpenChannelToExtension(
       renderframe->GetRoutingID(), info, channel_name, include_tls_channel_id,
       &port_id));
   args.GetReturnValue().Set(static_cast<int32_t>(port_id));
 }
 
 void RuntimeCustomBindings::OpenChannelToNativeApp(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   // Verify that the extension has permission to use native messaging.
@@ skipping 36 matching lines @@
 void RuntimeCustomBindings::GetExtensionViews(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   if (args.Length() != 2)
     return;
 
   if (!args[0]->IsInt32() || !args[1]->IsString())
     return;
 
   // |browser_window_id| == extension_misc::kUnknownWindowId means getting
   // all views for the current extension.
-  int browser_window_id = args[0]->Int32Value();
+  int browser_window_id = args[0].As<v8::Int32>()->Value();
 
   std::string view_type_string = *v8::String::Utf8Value(args[1]);
   StringToUpperASCII(&view_type_string);
   // |view_type| == VIEW_TYPE_INVALID means getting any type of
   // views.
   ViewType view_type = VIEW_TYPE_INVALID;
   if (view_type_string == kViewTypeBackgroundPage) {
     view_type = VIEW_TYPE_EXTENSION_BACKGROUND_PAGE;
   } else if (view_type_string == kViewTypeTabContents) {
     view_type = VIEW_TYPE_TAB_CONTENTS;
@@ skipping 18 matching lines @@
   std::vector<content::RenderView*> views = ExtensionHelper::GetExtensionViews(
       extension_id, browser_window_id, view_type);
   v8::Local<v8::Array> v8_views = v8::Array::New(args.GetIsolate());
   int v8_index = 0;
   for (size_t i = 0; i < views.size(); ++i) {
     v8::Local<v8::Context> context =
         views[i]->GetWebView()->mainFrame()->mainWorldScriptContext();
     if (!context.IsEmpty()) {
       v8::Local<v8::Value> window = context->Global();
       DCHECK(!window.IsEmpty());
-      v8_views->Set(v8::Integer::New(args.GetIsolate(), v8_index++), window);
+      auto maybe = v8_views->Set(
+          context, v8::Integer::New(args.GetIsolate(), v8_index++), window);
+      if (maybe.IsNothing() || !maybe.FromJust())
+        return;
     }
   }
 
   args.GetReturnValue().Set(v8_views);
 }
 
 }  // namespace extensions