Use V8 Maybe APIs in extensions/renderer

extensions/renderer/event_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/event_bindings.h"
 
 #include <map>
 
 #include "base/basictypes.h"
 #include "base/bind.h"
 #include "base/lazy_instance.h"
 #include "base/memory/scoped_ptr.h"
 #include "components/crx_file/id_util.h"
 #include "content/public/child/v8_value_converter.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/render_view.h"
 #include "extensions/common/event_filter.h"
 #include "extensions/common/extension.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/manifest_handlers/background_info.h"
 #include "extensions/common/value_counter.h"
 #include "extensions/renderer/extension_helper.h"
 #include "extensions/renderer/script_context.h"
+#include "extensions/renderer/v8_maybe_helpers.h"
 #include "url/gurl.h"
 
 namespace extensions {
 
 namespace {
 
 // A map of event names to the number of contexts listening to that event.
 // We notify the browser about event listeners when we transition between 0
 // and 1.
 typedef std::map<std::string, int> EventListenerCounts;
@@ skipping 45 matching lines @@
   if (!render_view)
     return false;
   ExtensionHelper* helper = ExtensionHelper::Get(render_view);
   return (extension && BackgroundInfo::HasLazyBackgroundPage(extension) &&
           helper->view_type() == VIEW_TYPE_EXTENSION_BACKGROUND_PAGE);
 }
 
 EventFilteringInfo ParseFromObject(v8::Local<v8::Object> object,
                                    v8::Isolate* isolate) {
   EventFilteringInfo info;
-  v8::Local<v8::String> url(v8::String::NewFromUtf8(isolate, "url"));
-  if (object->Has(url)) {
-    v8::Local<v8::Value> url_value(object->Get(url));
+  v8::Local<v8::String> url(ToV8String(isolate, "url"));
+  v8::Local<v8::Context> context = isolate->GetCurrentContext();
+  if (CheckV8Call(object->Has(context, url))) {
+    v8::Local<v8::Value> url_value(UnsafeGet(context, object, url));
     info.SetURL(GURL(*v8::String::Utf8Value(url_value)));
   }
-  v8::Local<v8::String> instance_id(
-      v8::String::NewFromUtf8(isolate, "instanceId"));
-  if (object->Has(instance_id)) {
-    v8::Local<v8::Value> instance_id_value(object->Get(instance_id));
-    info.SetInstanceID(instance_id_value->IntegerValue());
+  v8::Local<v8::String> instance_id(ToV8String(isolate, "instanceId"));
+  if (CheckV8Call(object->Has(context, instance_id))) {
+    v8::Local<v8::Value> instance_id_value(
+        UnsafeGet(context, object, instance_id));
+    info.SetInstanceID(
+        instance_id_value->IntegerValue(context).FromJust());
   }
-  v8::Local<v8::String> service_type(
-      v8::String::NewFromUtf8(isolate, "serviceType"));
-  if (object->Has(service_type)) {
-    v8::Local<v8::Value> service_type_value(object->Get(service_type));
+  v8::Local<v8::String> service_type(ToV8String(isolate, "serviceType"));
+  if (CheckV8Call(object->Has(context, service_type))) {
+    v8::Local<v8::Value> service_type_value(
+        UnsafeGet(context, object, service_type));
     info.SetServiceType(*v8::String::Utf8Value(service_type_value));
   }
   return info;
 }
 
 // Add a filter to |event_name| in |extension_id|, returning true if it
 // was the first filter for that event in that extension.
 bool AddFilter(const std::string& event_name,
                const std::string& extension_id,
                base::DictionaryValue* filter) {
@@ skipping 80 matching lines @@
     content::RenderThread::Get()->Send(
         new ExtensionHostMsg_AddLazyListener(extension_id, event_name));
   }
 }
 
 void EventBindings::DetachEventHandler(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   CHECK_EQ(2, args.Length());
   CHECK(args[0]->IsString());
   CHECK(args[1]->IsBoolean());
-  DetachEvent(*v8::String::Utf8Value(args[0]), args[1]->BooleanValue());
+  DetachEvent(*v8::String::Utf8Value(args[0]),
+              args[1].As<v8::Boolean>()->Value());
 }
 
 void EventBindings::DetachEvent(const std::string& event_name, bool is_manual) {
   // See comment in AttachEvent().
   attached_event_names_.erase(event_name);
 
   const std::string& extension_id = context()->GetExtensionID();
 
   if (DecrementEventListenerCount(context(), event_name) == 0) {
     content::RenderThread::Get()->Send(new ExtensionHostMsg_RemoveListener(
@@ skipping 59 matching lines @@
   }
 
   args.GetReturnValue().Set(static_cast<int32_t>(id));
 }
 
 void EventBindings::DetachFilteredEvent(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   CHECK_EQ(2, args.Length());
   CHECK(args[0]->IsInt32());
   CHECK(args[1]->IsBoolean());
-  bool is_manual = args[1]->BooleanValue();
+  bool is_manual = args[1].As<v8::Boolean>()->Value();
 
   std::string extension_id = context()->GetExtensionID();
 
-  int matcher_id = args[0]->Int32Value();
+  int matcher_id = args[0].As<v8::Int32>()->Value();
   EventFilter& event_filter = g_event_filter.Get();
   EventMatcher* event_matcher = event_filter.GetEventMatcher(matcher_id);
 
   const std::string& event_name = event_filter.GetEventName(matcher_id);
 
   // Only send IPCs the last time a filter gets removed.
   if (RemoveFilter(event_name, extension_id, event_matcher->value())) {
     bool lazy = is_manual && IsLazyBackgroundPage(context()->GetRenderView(),
                                                   context()->extension());
     content::RenderThread::Get()->Send(
         new ExtensionHostMsg_RemoveFilteredListener(
             extension_id, event_name, *event_matcher->value(), lazy));
   }
 
   event_filter.RemoveEventMatcher(matcher_id);
 }
 
 void EventBindings::MatchAgainstEventFilter(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
   v8::Isolate* isolate = args.GetIsolate();
   typedef std::set<EventFilter::MatcherID> MatcherIDs;
   EventFilter& event_filter = g_event_filter.Get();
   std::string event_name = *v8::String::Utf8Value(args[0]);
+  CHECK(args[1]->IsObject());
   EventFilteringInfo info =
-      ParseFromObject(args[1]->ToObject(isolate), isolate);
+      ParseFromObject(args[1].As<v8::Object>(), isolate);
   // Only match events routed to this context's RenderView or ones that don't
   // have a routingId in their filter.
   MatcherIDs matched_event_filters = event_filter.MatchEvent(
       event_name, info, context()->GetRenderView()->GetRoutingID());
   v8::Local<v8::Array> array(
       v8::Array::New(isolate, matched_event_filters.size()));
   int i = 0;
   for (MatcherIDs::iterator it = matched_event_filters.begin();
        it != matched_event_filters.end();
        ++it) {
-    array->Set(v8::Integer::New(isolate, i++), v8::Integer::New(isolate, *it));
+    SetProperty(isolate->GetCurrentContext(), array,
+                v8::Integer::New(isolate, i++), v8::Integer::New(isolate, *it));
   }
   args.GetReturnValue().Set(array);
 }
 
 scoped_ptr<EventMatcher> EventBindings::ParseEventMatcher(
     base::DictionaryValue* filter_dict) {
   return scoped_ptr<EventMatcher>(new EventMatcher(
       scoped_ptr<base::DictionaryValue>(filter_dict->DeepCopy()),
       context()->GetRenderView()->GetRoutingID()));
 }
 
 void EventBindings::OnInvalidated() {
   // Detach all attached events that weren't attached. Iterate over a copy
   // because it will be mutated.
   std::set<std::string> attached_event_names_safe = attached_event_names_;
   for (const std::string& event_name : attached_event_names_safe) {
     DetachEvent(event_name, false /* is_manual */);
   }
   DCHECK(attached_event_names_.empty())
       << "Events cannot be attached during invalidation";
 }
 
 }  // namespace extensions