Use V8 Maybe APIs in extensions/renderer

extensions/renderer/console.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/console.h"
 
 #include "base/compiler_specific.h"
 #include "base/debug/alias.h"
 #include "base/lazy_instance.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/public/renderer/render_view.h"
 #include "content/public/renderer/render_view_visitor.h"
 #include "extensions/renderer/dispatcher.h"
 #include "extensions/renderer/extension_helper.h"
+#include "extensions/renderer/v8_maybe_helpers.h"
 #include "third_party/WebKit/public/web/WebConsoleMessage.h"
 #include "third_party/WebKit/public/web/WebFrame.h"
 #include "third_party/WebKit/public/web/WebView.h"
 
 namespace extensions {
 namespace console {
 
 namespace {
 
 // Finds the RenderView associated with a context. Note: there will be multiple
@@ skipping 48 matching lines @@
       message += " ";
     message += *v8::String::Utf8Value(info[i]);
   }
   (*log_method)(info.GetIsolate()->GetCallingContext(), message);
 }
 
 void BindLogMethod(v8::Isolate* isolate,
                    v8::Local<v8::Object> target,
                    const std::string& name,
                    LogMethod log_method) {
+  CHECK(name.size() < v8::String::kMaxLength);
   v8::Local<v8::FunctionTemplate> tmpl = v8::FunctionTemplate::New(
       isolate,
       &BoundLogMethodCallback,
       v8::External::New(isolate, reinterpret_cast<void*>(log_method)));
-  target->Set(v8::String::NewFromUtf8(isolate, name.c_str()),
-              tmpl->GetFunction());
+  v8::Local<v8::String> property = ToV8String(isolate, name.c_str());
+  v8::Local<v8::Context> context = isolate->GetCurrentContext();
+  v8::Local<v8::Function> function;
+  if (!tmpl->GetFunction(context).ToLocal(&function))
+    NOTREACHED();
+  SetProperty(context, target, property, function);
 }
 
 }  // namespace
 
 void Debug(content::RenderView* render_view, const std::string& message) {
   AddMessage(render_view, content::CONSOLE_MESSAGE_LEVEL_DEBUG, message);
 }
 
 void Log(content::RenderView* render_view, const std::string& message) {
   AddMessage(render_view, content::CONSOLE_MESSAGE_LEVEL_LOG, message);
@@ skipping 79 matching lines @@
   v8::Local<v8::Object> console_object = v8::Object::New(isolate);
   BindLogMethod(isolate, console_object, "debug", &Debug);
   BindLogMethod(isolate, console_object, "log", &Log);
   BindLogMethod(isolate, console_object, "warn", &Warn);
   BindLogMethod(isolate, console_object, "error", &Error);
   return handle_scope.Escape(console_object);
 }
 
 }  // namespace console
 }  // namespace extensions