extensions/renderer/logging_native_handler.cc - Issue 1167423002: Use V8 Maybe APIs in extensions/renderer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/renderer/logging_native_handler.cc

Issue 1167423002: Use V8 Maybe APIs in extensions/renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/renderer/logging_native_handler.cc

diff --git a/extensions/renderer/logging_native_handler.cc b/extensions/renderer/logging_native_handler.cc

index 8a913a15f258af3340ea46d167300e564a5539c1..b665f751dec0f5bb250369bf8e65a9ee201ee606 100644

--- a/extensions/renderer/logging_native_handler.cc

+++ b/extensions/renderer/logging_native_handler.cc

@@ -67,7 +67,12 @@ void LoggingNativeHandler::ParseArgs(

bool* check_value,

std::string* error_message) {

CHECK_LE(args.Length(), 2);

- *check_value = args[0]->BooleanValue();

+ auto maybe = args[0]->BooleanValue(args.GetIsolate()->GetCurrentContext());

+ if (maybe.IsNothing()) {

+ *error_message = "Error: Cannot continue execution.";

+ return;

+ }

+ *check_value = maybe.FromJust();

if (args.Length() == 2) {

*error_message = "Error: " + std::string(*v8::String::Utf8Value(args[1]));

}