Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: extensions/renderer/native_handler.h

Issue 1167423002: Use V8 Maybe APIs in extensions/renderer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_NATIVE_HANDLER_H_ 5 #ifndef EXTENSIONS_RENDERER_NATIVE_HANDLER_H_
6 #define EXTENSIONS_RENDERER_NATIVE_HANDLER_H_ 6 #define EXTENSIONS_RENDERER_NATIVE_HANDLER_H_
7 7
8 #include "base/basictypes.h" 8 #include "base/basictypes.h"
9 #include "v8/include/v8.h" 9 #include "v8/include/v8.h"
10 10
11 namespace extensions { 11 namespace extensions {
12 12
13 // NativeHandlers are intended to be used with a ModuleSystem. The ModuleSystem 13 // NativeHandlers are intended to be used with a ModuleSystem. The ModuleSystem
14 // will assume ownership of the NativeHandler, and as a ModuleSystem is tied to 14 // will assume ownership of the NativeHandler, and as a ModuleSystem is tied to
15 // a single v8::Context, this implies that NativeHandlers will also be tied to 15 // a single v8::Context, this implies that NativeHandlers will also be tied to
16 // a single v8::Context. 16 // a single v8::Context.
17 // TODO(koz): Rename this to NativeJavaScriptModule. 17 // TODO(koz): Rename this to NativeJavaScriptModule.
18 class NativeHandler { 18 class NativeHandler {
19 public: 19 public:
20 NativeHandler(); 20 NativeHandler();
21 virtual ~NativeHandler(); 21 virtual ~NativeHandler();
22 22
23 // Create a new instance of the object this handler specifies. 23 // Create a new instance of the object this handler specifies.
24 virtual v8::Local<v8::Object> NewInstance() = 0; 24 virtual v8::MaybeLocal<v8::Object> NewInstance() = 0;
25 25
26 // Invalidate this object so it cannot be used any more. This is needed 26 // Invalidate this object so it cannot be used any more. This is needed
27 // because it's possible for this to outlive its owner context. Invalidate 27 // because it's possible for this to outlive its owner context. Invalidate
28 // must be called before this happens. 28 // must be called before this happens.
29 // 29 //
30 // Subclasses should override to invalidate their own V8 state. If they do 30 // Subclasses should override to invalidate their own V8 state. If they do
31 // they must call their superclass' Invalidate(). 31 // they must call their superclass' Invalidate().
32 // 32 //
33 // Invalidate() will be called on destruction, if it hasn't already been. 33 // Invalidate() will be called on destruction, if it hasn't already been.
34 // Subclasses don't need to do it themselves. 34 // Subclasses don't need to do it themselves.
35 virtual void Invalidate(); 35 virtual void Invalidate();
36 36
37 protected: 37 protected:
38 // Allow subclasses to query valid state. 38 // Allow subclasses to query valid state.
39 bool is_valid() { return is_valid_; } 39 bool is_valid() { return is_valid_; }
40 40
41 private: 41 private:
42 bool is_valid_; 42 bool is_valid_;
43 43
44 DISALLOW_COPY_AND_ASSIGN(NativeHandler); 44 DISALLOW_COPY_AND_ASSIGN(NativeHandler);
45 }; 45 };
46 46
47 } // namespace extensions 47 } // namespace extensions
48 48
49 #endif // EXTENSIONS_RENDERER_NATIVE_HANDLER_H_ 49 #endif // EXTENSIONS_RENDERER_NATIVE_HANDLER_H_
OLDNEW
« no previous file with comments | « extensions/renderer/module_system_unittest.cc ('k') | extensions/renderer/object_backed_native_handler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698