Use V8 Maybe APIs in extensions/renderer

extensions/renderer/i18n_custom_bindings.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "extensions/renderer/i18n_custom_bindings.h"
 
 #include "base/bind.h"
 #include "content/public/renderer/render_thread.h"
 #include "content/public/renderer/render_view.h"
 #include "extensions/common/extension_messages.h"
 #include "extensions/common/message_bundle.h"
 #include "extensions/renderer/script_context.h"
+#include "extensions/renderer/v8_maybe_helpers.h"
 
 namespace extensions {
 
 I18NCustomBindings::I18NCustomBindings(ScriptContext* context)
     : ObjectBackedNativeHandler(context) {
   RouteFunction(
       "GetL10nMessage",
       base::Bind(&I18NCustomBindings::GetL10nMessage, base::Unretained(this)));
   RouteFunction("GetL10nUILanguage",
                 base::Bind(&I18NCustomBindings::GetL10nUILanguage,
@@ skipping 43 matching lines @@
 
   v8::Isolate* isolate = args.GetIsolate();
   std::vector<std::string> substitutions;
   if (args[1]->IsArray()) {
     // chrome.i18n.getMessage("message_name", ["more", "params"]);
     v8::Local<v8::Array> placeholders = v8::Local<v8::Array>::Cast(args[1]);
     uint32_t count = placeholders->Length();
     if (count > 9)
       return;
     for (uint32_t i = 0; i < count; ++i) {
-      substitutions.push_back(*v8::String::Utf8Value(placeholders->Get(
-          v8::Integer::New(isolate, i))));
+      v8::Local<v8::Value> param;
+      if (!placeholders->Get(isolate->GetCurrentContext(),
+                             v8::Integer::New(isolate, i))
+               .ToLocal(&param))
+        return;
+      substitutions.push_back(*v8::String::Utf8Value(param));
     }
   } else if (args[1]->IsString()) {
     // chrome.i18n.getMessage("message_name", "one param");
     substitutions.push_back(*v8::String::Utf8Value(args[1]));
   }
 
-  args.GetReturnValue().Set(v8::String::NewFromUtf8(
-      isolate,
-      ReplaceStringPlaceholders(message, substitutions, NULL).c_str()));
+  std::string ret_value =
+      ReplaceStringPlaceholders(message, substitutions, NULL);
+  if (ret_value.size() >= v8::String::kMaxLength)
+    return;
+  args.GetReturnValue().Set(ToV8String(isolate, ret_value.c_str()));
 }
 
 void I18NCustomBindings::GetL10nUILanguage(
     const v8::FunctionCallbackInfo<v8::Value>& args) {
-  args.GetReturnValue().Set(v8::String::NewFromUtf8(
+  args.GetReturnValue().Set(ToV8String(
       args.GetIsolate(), content::RenderThread::Get()->GetLocale().c_str()));
 }
 
 }  // namespace extensions